Popup javascript does not fire as expected due to Bootstrap 5 changes

[Syxton]

These are the changes I made to get the popup setting to work again in Moodle 5.x

[gjb2048]

@Syxton Not sure why the CSS attribute is needed and why it is inline rather than in the styles file -> 22e7ac3#diff-9dec2f9b87bcd30f64bf08a6c119fa45d03cfeeac0d8fb9dfb1dcf95f3bdf628L152.

[Syxton]

@gjb2048 It wasn't related to the bug...it was just added while I was fixing what I was seeing. The X button on the modal was bunched up against the section title. Looks more natural in the right corner.

you are right. adding:
.format-grid .modal-header {
justify-content: space-between;
}

to styles.css is better, I shouldn't have added that in the pull

[gjb2048]

@Syxton Interesting! Looks like happens in Boost but not Adaptable (where I was testing), which has:

.modal-header .close {
  margin-left: auto;
}

[Syxton]

Looks and behaves correctly with the new commit including the style change. Thanks!