-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rename detection & async filling for file revlog #2589
base: master
Are you sure you want to change the base?
Add rename detection & async filling for file revlog #2589
Conversation
find more renames that git-log --follow would simplify
877fbf9
to
c9d5b5c
Compare
The current algorithm does not correctly deal with renames in branches:
File revlog of gitui in
@extrawurst: I would argue that until the issue missing an obvious change to a file is fixed, we either should abstain from merging this or we should make this feature optional. Rename following can at most be done heuristically anyhow and I'd suggest that it should always be optional, even if the issue above would be resolved. It should be straightforward to resolve this with a graph-aware log walker, though. (Also, have not checked, just a note for myself: Currently, the log walker orders commit by time. It should use topological ordering instead.) |
This is an initial draft for an update to #1881. I've rebased onto the current master, connected the output path, fixed some first issues and made clippy happy.
There's still a lot to do, but this should already work for testing the UI.
This Pull Request fixes/closes #{issue_num}.
It changes the following:
I followed the checklist:
make check
without errors