This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
fix: check for root #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaked
reviewed
Nov 18, 2022
Comment on lines
+80
to
+82
| if (root) { | ||
| root.render(component); | ||
| } else { |
There was a problem hiding this comment.
I think this will never run, since let root is scoped to the function and will be recreated as undefined every run. You could do it with a let outside the function (but I'm not sure what happens to these if the code is reloaded).
There was a problem hiding this comment.
Curious, that's not what I was observing on my end.
Closing out this patch in any case!
There was a problem hiding this comment.
ok I did not actually test it, you may be right! (@Wattenberger and I ended up stripping out the React code here anyway, not sure if she pushed the work we did Friday)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the Todo item about HMR not working.
I'm not sure I fully understand which of these implementation details we want to hide from end users – is this too in the weeds for the actual block template itself?