Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to downloading databases and the CLI #3373

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

koesie10
Copy link
Member

This adds timeouts to downloading CodeQL databases and the CLI. The default for both is 10 seconds, meaning that if no data is received for at least 10 seconds, the download is cancelled with a timeout error. There are configurable settings for both timeouts to allow users with poor internet connections to configure these with longer timeouts.

Screenshot 2024-02-19 at 14 07 57

Closes #903
Closes #3204

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/download-timeout branch from f18a0de to 1a9c792 Compare February 19, 2024 15:15
@koesie10 koesie10 marked this pull request as ready for review February 19, 2024 16:01
@koesie10 koesie10 requested review from a team as code owners February 19, 2024 16:01
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

Do we need to update the CHANGELOG/any docs? Is Product aware of the new setting?

@koesie10 koesie10 enabled auto-merge February 22, 2024 12:27
@koesie10 koesie10 merged commit b826ed3 into main Feb 22, 2024
27 checks passed
@koesie10 koesie10 deleted the koesie10/download-timeout branch February 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database download gets stuck on connection issues CodeQL CLI download failure causes extension to get stuck
2 participants