Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for complex access path suggestions #3291

Closed
wants to merge 1 commit into from

Conversation

shati-patel
Copy link
Contributor

Adds a bunch of types that we'll need for showing complex access path suggestions in the model editor. See internal linked issue for more context.

Note: these currently aren't used (and will probably break the deadcode CI check 🙃)

Checklist

N/A

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel
Copy link
Contributor Author

Closing this for now. Even when unexporting the types, a bunch of definitions still aren't used, so this PR would become pretty empty. It makes more sense to include the relevant types along with their usage, e.g. in #3292

@shati-patel shati-patel deleted the shati-patel/suggestion-types branch January 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant