Don't accidentally mix DTO and non-DTO types in query-history-store.test.ts #3290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit some errors in https://github.com/github/vscode-codeql/actions/runs/7695850568/job/20969605471?pr=3287 and this made me realise that
query-history-store.test.ts
is being a bit naughty when writing test data. We're writing the query history file but the data being written is the internal query history types instead of the query history DTO types.This PR introduces a
writeRawQueryHistory
method which accepts the correctQueryHistoryDto
type and writes it to disk. Hopefully this will help avoid people making the same mistake in the future by discouraging direct use ofwriteFileSync
and writing incorrect JSON.When I merge this branch into the
robertbrignull/move_language_pack
branch then theno-workspace
tests pass locally (where they don't before) so that convinces me this change is correct.Checklist
ready-for-doc-review
label there.