Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using Tab to select the active option in the suggest box #3288

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Allow using Tab to select the active option in the suggest box #3288

merged 1 commit into from
Jan 30, 2024

Conversation

koesie10
Copy link
Member

This adds Tab as a key that will select the active item in the suggest box, as suggested in #3242 (review).

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review January 30, 2024 09:27
@koesie10 koesie10 requested a review from a team as a code owner January 30, 2024 09:27
@koesie10 koesie10 requested a review from a team January 30, 2024 09:27
norascheuch
norascheuch approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@koesie10 koesie10 merged commit e3a9c06 into main Jan 30, 2024
26 checks passed
@koesie10 koesie10 deleted the koesie10/suggest-box-tab branch January 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @norascheuch