Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store multiple queries on variant analysis object #3285

Closed
wants to merge 2 commits into from

Conversation

robertbrignull
Copy link
Contributor

The idea here is to update the VariantAnalysis to store info for multiple queries. When showing the results view or otherwise displaying anything about the variant analysis, we just use data for the first query. The intention of this PR is that everything should work exactly as before when there's only one query, but it's not expected to do anything sensible yet when there are multiple queries.

Also note that this is just changing the internal type, and this PR isn't changing the query history types or any other data that is stored or sent outside of the extension.

This PR did end up a little larger than I expected it to. I wasn't expecting this change to the type to affect so many places. Wherever I've had to put in a hack of using the first query, I've added a TODO comment. My hope is that we can go through and remove these as we convert the rest of the extension to handle multiple queries.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull
Copy link
Contributor Author

I've pulled out part of this to #3287

@robertbrignull
Copy link
Contributor Author

I'll close this PR since it's become a bit stale, and if we want to reproduce it then making the changes again isn't hard.

@robertbrignull robertbrignull deleted the robertbrignull/store_multiple_queries branch February 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant