Store multiple queries on variant analysis object #3285
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to update the
VariantAnalysis
to store info for multiple queries. When showing the results view or otherwise displaying anything about the variant analysis, we just use data for the first query. The intention of this PR is that everything should work exactly as before when there's only one query, but it's not expected to do anything sensible yet when there are multiple queries.Also note that this is just changing the internal type, and this PR isn't changing the query history types or any other data that is stored or sent outside of the extension.
This PR did end up a little larger than I expected it to. I wasn't expecting this change to the type to affect so many places. Wherever I've had to put in a hack of using the first query, I've added a TODO comment. My hope is that we can go through and remove these as we convert the rest of the extension to handle multiple queries.
Checklist
ready-for-doc-review
label there.