Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tree sitter to version 0.24 #472

Merged
merged 18 commits into from
Dec 12, 2024
Merged

Conversation

hendrikvanantwerpen
Copy link
Collaborator

@hendrikvanantwerpen hendrikvanantwerpen commented Dec 12, 2024

Several changes I still had lying around that would be pity to lose. They touch many files, but are mostly not very interesting.

  • Upgrade to tree-sitter version 0.24.
    • A few stack graph rules files changed because of grammar changes, most notably for TypeScript. Since behavior remained the same and no tests changed, reviewing these in-depth is probably not necessary.
  • Fix a Valgrind problem introduced by Rust 1.83.
    • cargo-valgrind made it difficult to save the logs and get the actual trace to suppress. That's why I replaced cargo-valgrind with a custom ci-test-valgrind script.
  • Updated actions version to v4, since v3 was not always supported anymore.

Copy link

Performance Summary

Comparing base 9649181 with head af72222 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.275^                                                  ##                    
     |                                                  #                     
     |                                                 :#                     
     |                                              ::::#                     
     |                                              :  :#                   ::
     |                                              :  :#                   ::
     |                                            :::  :#                @@@::
     |                                          :@: :  :#                @  ::
     |                                          :@: :  :#                @  ::
     |                                     @    :@: :  :#             :::@  ::
     |                     @  @@          @@  :::@: :  :#      :@@ ::::  @  ::
     |                    @@::@  : :     :@@::: :@: :  :#      :@ ::: :  @  ::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   90.55
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.723^                                                                       #
     |                                                                       #
     |                                                                       #
     |                                                                       #
     |                                                                     ::#
     |                                                                    @: #
     |                                                                    @: #
     |                                                 @@       ::@     ::@: #
     |                                 @               @        ::@   ::: @: #
     |                          :      @             @@@ :     :::@:: : : @: #
     |                         @: ::@::@     :       @ @ :    ::::@:: : : @: #
     |                        @@::: @::@ :::::::::  :@ @ :    ::::@:::: : @: #
   0 +----------------------------------------------------------------------->Gi
     0                                                                   73.44

Copy link

Performance Summary

Comparing base 9649181 with head 88adb24 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.275^                                                  ##                    
     |                                                  #                     
     |                                                 :#                     
     |                                              ::::#                     
     |                                              :  :#                   ::
     |                                              :  :#                   ::
     |                                            :::  :#                @@@::
     |                                          :@: :  :#                @  ::
     |                                          :@: :  :#                @  ::
     |                                     @    :@: :  :#             :::@  ::
     |                     @  @@          @@  :::@: :  :#      :@@ ::::  @  ::
     |                    @@::@  : :     :@@::: :@: :  :#      :@ ::: :  @  ::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   90.55
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.723^                                                                       #
     |                                                                       #
     |                                                                       #
     |                                                                      @#
     |                                                                     :@#
     |                                                                    @:@#
     |                                                                    @:@#
     |                                                 @        :@:     ::@:@#
     |                                @@               @        :@:   ::: @:@#
     |                                @              @@@:      ::@::: : : @:@#
     |                         @: ::::@      :       @ @:      ::@::: : : @:@#
     |                        @@::: ::@  @@::: ::   :@ @:      ::@::::: : @:@#
   0 +----------------------------------------------------------------------->Gi
     0                                                                   73.43

Copy link

Performance Summary

Comparing base 9649181 with head 9998fbd on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.275^                                                  ##                    
     |                                                  #                     
     |                                                 :#                     
     |                                              ::::#                     
     |                                              :  :#                   ::
     |                                              :  :#                   ::
     |                                            :::  :#                @@@::
     |                                          :@: :  :#                @  ::
     |                                          :@: :  :#                @  ::
     |                                     @    :@: :  :#             :::@  ::
     |                     @  @@          @@  :::@: :  :#      :@@ ::::  @  ::
     |                    @@::@  : :     :@@::: :@: :  :#      :@ ::: :  @  ::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   90.55
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.723^                                                                       #
     |                                                                       #
     |                                                                       #
     |                                                                       #
     |                                                                     ::#
     |                                                                     : #
     |                                                                     : #
     |                                                 @@       ::@     :::: #
     |                                 @               @        ::@  :  :  : #
     |                                 @             @@@ :     :::@::::::  : #
     |                         @: ::@::@      :      @ @ :    ::::@:::  :  : #
     |                        @@::: @::@ :: @@::::  :@ @ :    ::::@:::  :  : #
   0 +----------------------------------------------------------------------->Gi
     0                                                                   73.43

@hendrikvanantwerpen hendrikvanantwerpen marked this pull request as ready for review December 12, 2024 14:52
@Copilot Copilot bot review requested due to automatic review settings December 12, 2024 14:52
@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner December 12, 2024 14:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

@hendrikvanantwerpen hendrikvanantwerpen merged commit 123350f into main Dec 12, 2024
17 checks passed
@hendrikvanantwerpen hendrikvanantwerpen deleted the upgrade-tree-sitter branch December 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants