-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Rovodev CLI Support #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheManWhoLikesToCode
wants to merge
8
commits into
github:main
Choose a base branch
from
TheManWhoLikesToCode:Rovodev-CLI-Support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−28
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
eff26e1
Rovodev CLI Support
TheManWhoLikesToCode c84bef8
Update scripts/update-agent-context.sh
TheManWhoLikesToCode 3be23e9
Apply suggestion from @Copilot
TheManWhoLikesToCode 7ab296d
Apply suggestion from @Copilot
TheManWhoLikesToCode e57469d
consistent naming of Rovo Dev CLI
TheManWhoLikesToCode a33d885
workflows updated
TheManWhoLikesToCode e6ce207
remove fallback logic now we have templates
TheManWhoLikesToCode 214c8d9
Revert "remove fallback logic now we have templates"
TheManWhoLikesToCode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -51,7 +51,8 @@ | |||||
| AI_CHOICES = { | ||||||
| "copilot": "GitHub Copilot", | ||||||
| "claude": "Claude Code", | ||||||
| "gemini": "Gemini CLI" | ||||||
| "gemini": "Gemini CLI", | ||||||
| "rovodevcli": "Rovo Dev CLI", | ||||||
| } | ||||||
|
|
||||||
| # ASCII Art Banner | ||||||
|
|
@@ -405,23 +406,30 @@ def download_template_from_github(ai_assistant: str, download_dir: Path, *, verb | |||||
| console.print(f"[red]Error fetching release information:[/red] {e}") | ||||||
| raise typer.Exit(1) | ||||||
|
|
||||||
| # Find the template asset for the specified AI assistant | ||||||
| # Find the template asset for the specified AI assistant, with fallback for 'rovodevcli' -> 'copilot' | ||||||
| pattern = f"spec-kit-template-{ai_assistant}" | ||||||
| matching_assets = [ | ||||||
| asset for asset in release_data.get("assets", []) | ||||||
| if pattern in asset["name"] and asset["name"].endswith(".zip") | ||||||
| ] | ||||||
|
|
||||||
| if not matching_assets: | ||||||
| assets = release_data.get("assets", []) | ||||||
| matching_assets = [a for a in assets if pattern in a["name"] and a["name"].endswith(".zip")] | ||||||
|
|
||||||
| asset = None | ||||||
| if matching_assets: | ||||||
| asset = matching_assets[0] | ||||||
| elif ai_assistant == "rovodevcli": | ||||||
| # Fallback to copilot template if rovodevcli-specific template is not published yet | ||||||
| fallback_pattern = "spec-kit-template-copilot" | ||||||
| fallback_assets = [a for a in assets if fallback_pattern in a["name"] and a["name"].endswith(".zip")] | ||||||
| if fallback_assets: | ||||||
| asset = fallback_assets[0] | ||||||
| if verbose: | ||||||
| console.print("[yellow]No 'rovodevcli' template found; falling back to 'copilot' template.[/yellow]") | ||||||
|
Comment on lines
+417
to
+424
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The fallback logic is hardcoded specifically for "rovodevcli". Consider extracting this into a configurable fallback mapping (e.g., Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
|
|
||||||
| if asset is None: | ||||||
| if verbose: | ||||||
| console.print(f"[red]Error:[/red] No template found for AI assistant '{ai_assistant}'") | ||||||
| console.print(f"[yellow]Available assets:[/yellow]") | ||||||
| for asset in release_data.get("assets", []): | ||||||
| console.print(f" - {asset['name']}") | ||||||
| for a in assets: | ||||||
| console.print(f" - {a['name']}") | ||||||
| raise typer.Exit(1) | ||||||
|
|
||||||
| # Use the first matching asset | ||||||
| asset = matching_assets[0] | ||||||
| download_url = asset["browser_download_url"] | ||||||
| filename = asset["name"] | ||||||
| file_size = asset["size"] | ||||||
|
|
@@ -638,7 +646,7 @@ def download_and_extract_template(project_path: Path, ai_assistant: str, is_curr | |||||
| @app.command() | ||||||
| def init( | ||||||
| project_name: str = typer.Argument(None, help="Name for your new project directory (optional if using --here)"), | ||||||
| ai_assistant: str = typer.Option(None, "--ai", help="AI assistant to use: claude, gemini, or copilot"), | ||||||
| ai_assistant: str = typer.Option(None, "--ai", help="AI assistant to use: claude, gemini, copilot, or rovodevcli"), | ||||||
| ignore_agent_tools: bool = typer.Option(False, "--ignore-agent-tools", help="Skip checks for AI agent tools like Claude Code"), | ||||||
| no_git: bool = typer.Option(False, "--no-git", help="Skip git repository initialization"), | ||||||
| here: bool = typer.Option(False, "--here", help="Initialize project in the current directory instead of creating a new one"), | ||||||
|
|
@@ -648,7 +656,7 @@ def init( | |||||
|
|
||||||
| This command will: | ||||||
| 1. Check that required tools are installed (git is optional) | ||||||
| 2. Let you choose your AI assistant (Claude Code, Gemini CLI, or GitHub Copilot) | ||||||
| 2. Let you choose your AI assistant (Claude Code, Gemini CLI, GitHub Copilot, or Rovo Dev CLI) | ||||||
| 3. Download the appropriate template from GitHub | ||||||
| 4. Extract the template to a new project directory or current directory | ||||||
| 5. Initialize a fresh git repository (if not --no-git and no existing repo) | ||||||
|
|
@@ -659,8 +667,10 @@ def init( | |||||
| specify init my-project --ai claude | ||||||
| specify init my-project --ai gemini | ||||||
| specify init my-project --ai copilot --no-git | ||||||
| specify init my-project --ai rovodevcli | ||||||
| specify init --ignore-agent-tools my-project | ||||||
| specify init --here --ai claude | ||||||
| specify init --here --ai rovodevcli | ||||||
| specify init --here | ||||||
| """ | ||||||
| # Show banner first | ||||||
|
|
@@ -737,6 +747,10 @@ def init( | |||||
| if not check_tool("gemini", "Install from: https://github.com/google-gemini/gemini-cli"): | ||||||
| console.print("[red]Error:[/red] Gemini CLI is required for Gemini projects") | ||||||
| agent_tool_missing = True | ||||||
| elif selected_ai == "rovodevcli": | ||||||
| if not check_tool("acli", "Install from: https://support.atlassian.com/rovo/docs/install-and-run-rovo-dev-cli-on-your-device"): | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The URL is quite long and makes the line exceed reasonable length limits. Consider storing the installation URL in a constant or variable for better readability. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| console.print("[red]Error:[/red] Rovo Dev CLI is required for Rovo Dev CLI projects") | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The error message "Rovo Dev CLI is required for Rovo Dev CLI projects" is redundant. Consider changing to "Rovo Dev CLI (acli) is required for Rovo Dev projects" to be more informative and consistent with other error messages.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| agent_tool_missing = True | ||||||
| # GitHub Copilot check is not needed as it's typically available in supported IDEs | ||||||
|
|
||||||
| if agent_tool_missing: | ||||||
|
|
@@ -823,6 +837,12 @@ def init( | |||||
| steps_lines.append(" - See GEMINI.md for all available commands") | ||||||
| elif selected_ai == "copilot": | ||||||
| steps_lines.append(f"{step_num}. Open in Visual Studio Code and use [bold cyan]/specify[/], [bold cyan]/plan[/], [bold cyan]/tasks[/] commands with GitHub Copilot") | ||||||
| elif selected_ai == "rovodevcli": | ||||||
| steps_lines.append(f"{step_num}. Use / commands with Rovo Dev CLI") | ||||||
| steps_lines.append(" - Use /specify to create specifications") | ||||||
| steps_lines.append(" - Use /plan to create implementation plans") | ||||||
| steps_lines.append(" - Use /tasks to generate tasks") | ||||||
| steps_lines.append(" - See agent.md for all available commands") | ||||||
|
|
||||||
| step_num += 1 | ||||||
| steps_lines.append(f"{step_num}. Update [bold magenta]CONSTITUTION.md[/bold magenta] with your project's non-negotiable principles") | ||||||
|
|
@@ -855,11 +875,13 @@ def check(): | |||||
| console.print("\n[cyan]Optional AI tools:[/cyan]") | ||||||
| claude_ok = check_tool("claude", "Install from: https://docs.anthropic.com/en/docs/claude-code/setup") | ||||||
| gemini_ok = check_tool("gemini", "Install from: https://github.com/google-gemini/gemini-cli") | ||||||
| rovodevcli_ok = check_tool("acli", "Install from: https://support.atlassian.com/rovo/docs/install-and-run-rovo-dev-cli-on-your-device") | ||||||
|
|
||||||
|
|
||||||
| console.print("\n[green]✓ Specify CLI is ready to use![/green]") | ||||||
| if not git_ok: | ||||||
| console.print("[yellow]Consider installing git for repository management[/yellow]") | ||||||
| if not (claude_ok or gemini_ok): | ||||||
| if not (claude_ok or gemini_ok or rovodevcli_ok): | ||||||
| console.print("[yellow]Consider installing an AI assistant for the best experience[/yellow]") | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback logic for rovodevcli -> copilot template mentioned in the comment is not implemented. The code should attempt to find the copilot template when rovodevcli template is not found.
Copilot uses AI. Check for mistakes.