-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement target-api-url
for generate-script
commands
#1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target-api-url
for generate-script
target-api-url
for generate-script
commands
Unit Test Results810 tests 810 ✅ 21s ⏱️ Results for commit 54158a7. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just left some comments to use our HasValue()
extension method instead of !string.IsNullOrEmpty()
src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/gei/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/gei/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/gei/Commands/GenerateScript/GenerateScriptCommandHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Arin Ghazarian <[email protected]>
Co-authored-by: Arin Ghazarian <[email protected]>
Co-authored-by: Arin Ghazarian <[email protected]>
…r.cs Co-authored-by: Arin Ghazarian <[email protected]>
…r.cs Co-authored-by: Arin Ghazarian <[email protected]>
…r.cs Co-authored-by: Arin Ghazarian <[email protected]>
…r.cs Co-authored-by: Arin Ghazarian <[email protected]>
…r.cs Co-authored-by: Arin Ghazarian <[email protected]>
ArinGhazarian
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
target-api-url
forgenerate-script
commands that leverages prev work formigrate-repo
download-logs
wait-for-migration
.last one for #1094 and https://github.ghe.com/github/octoshift/issues/7956
Note: These unit tests were extremely tricky for me, I did some functional testing in original issue but spending over a day on unit tests is my limit.
ThirdPartyNotices.txt
(if applicable)