Rust: Implement toString on type aliases and add docs #19130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
rust-type-alias-string
branch
from
8be531e to
0d75054
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation examples for the GenericParamList and TypeAlias annotations, helping to clarify their usage now that toString functionality has been implemented.
- Updated the GenericParamList example by replacing a placeholder with a concrete function signature.
- Revised the TypeAlias example by providing a realistic usage snippet along with a trait definition.
Files not reviewed (7)
- rust/ql/.generated.list: Language not supported
- rust/ql/.gitattributes: Language not supported
- rust/ql/lib/codeql/rust/elements/GenericParamList.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/TypeAlias.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/internal/GenericParamListImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/internal/TypeAliasImpl.qll: Language not supported
- rust/ql/test/library-tests/path-resolution/path-resolution.expected: Language not supported
Comments suppressed due to low confidence (2)
rust/schema/annotations.py:1128
- Consider adding an example that demonstrates the use of the new toString implementation for type aliases to fully illustrate its behavior.
fn f<A, B>(a: A, b: B) {}
rust/schema/annotations.py:1713
- Including an additional example that calls the toString method on a type alias could help clarify the intended behavior as specified in the PR title.
type Point = (u8, u8);
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
reviewed
Mar 27, 2025
| class TypeAlias extends Generated::TypeAlias { } | ||
| class TypeAlias extends Generated::TypeAlias { | ||
| override string toStringImpl() { | ||
| result = concat(int i | | this.toStringPart(i), "" order by i) |
There was a problem hiding this comment.
I don't think the , "" bit is needed?
hvitved
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.