Skip to content

Fix typo and update generation script message. #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix typo and update generation script message. #756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94ab82
Fix typo and update generation script message.
fjatWbyT Oct 18, 2024
e7c4766
Merge branch 'main' into typo-script-help-message
lcartey Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions scripts/generate_rules/generate_package_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,10 @@ def generate_short_name(title):
json.dump(package_description, rule_package_file, indent=2, sort_keys=True)
print("Rule package file generated at " + str(rule_package_file_path) + ".")
print("")
print("A default query has been generated for each for each rule. Please review each rule in the generated JSON file and:")
print("A default query has been generated for each rule. Please review each rule in the generated JSON file and:")
print(" (1) Add additional queries as required")
print(" (2) Confirm that the following auto-generated properties are appropriate:")
print(" - 'camel_name'.")
print(" - 'precision'.")
print(" - 'query_name'.")
print(" - 'short_name'.")
print(" - 'severity'.")
print(" (3) Add additional 'tags' as required, particularly 'security' or 'correctness'.")
Loading