-
Notifications
You must be signed in to change notification settings - Fork 401
Gate tools: toolcache
behind FF
#3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mainly to allow us to disable it, if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a test too. Otherwise just one small thing to fix and one general comment.
UseRepositoryProperties = "use_repository_properties", | ||
QaTelemetryEnabled = "qa_telemetry_enabled", | ||
ResolveSupportedLanguagesUsingCli = "resolve_supported_languages_using_cli", | ||
UseRepositoryProperties = "use_repository_properties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Is there a lint rule for alphabetical enums we can enable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
ec1db76
to
dc2ced8
Compare
We merged support for this in #3175. It might be useful to be able to disable this functionality, so this PR adds a FF check for it.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning
).analysis-kinds: code-quality
).upload-sarif
).How did/will you validate this change?
.test.ts
files).pr-checks
).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist