Skip to content

Conversation

mario-campos
Copy link
Contributor

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
    • Changes should only apply to new v4 tag, once it's released; v3 should continue to work as-is.
    • All tests are passing.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mario-campos mario-campos marked this pull request as ready for review October 1, 2025 13:54
@mario-campos mario-campos requested a review from a team as a code owner October 1, 2025 13:54
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 13:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the CodeQL Action's Node.js runtime from v20 to v24 for the upcoming v4 release. This represents a major runtime upgrade to modernize the action's execution environment.

Key changes:

  • Updated all action.yml files to use Node.js v24 runtime instead of v20
  • Updated package.json and build configuration to target Node.js v24
  • Updated test fixtures and documentation to reference v4 instead of v3
  • Modified CI workflows to test on both Node.js 20 and 24 versions

Reviewed Changes

Copilot reviewed 30 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
action.yml files Updated runtime specification from node20 to node24 for all actions
package.json Updated version to 4.30.6 and @types/node to v24.5.2
lib/*.js files Generated JavaScript files updated with new version and Node.js target
test files Updated test fixtures to use v4 action references instead of v3
build.mjs Updated esbuild target from node20 to node24
workflow files Updated CI to test on both Node.js 20 and 24 versions
documentation Updated README and CONTRIBUTING to reflect v4 support and Node.js 24 requirement
Files not reviewed (1)
  • package-lock.json: Language not supported

henrymercer
henrymercer previously approved these changes Oct 1, 2025
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I only have a very minor suggested change to the README.

Before merging this, we'll need to update the set of required checks — there's instructions on how to do that here: https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#keeping-the-pr-checks-up-to-date-admin-access-required

henrymercer
henrymercer previously approved these changes Oct 1, 2025
mbg
mbg previously approved these changes Oct 3, 2025
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my feedback and tackling this important work!

henrymercer
henrymercer previously approved these changes Oct 3, 2025
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this until Monday, and then kick off a release right after we merge.

@henrymercer
Copy link
Contributor

Also, it looks like there are a couple of merge conflicts to solve. You'll probably need a re-approval after fixing them.

@mario-campos
Copy link
Contributor Author

Weirdly, I don't see those merge conflicts:

mario-campos@G49XGKM6FH ~/codeql-action (mario-campos/node24)> git status
On branch mario-campos/node24
Your branch is up to date with 'origin/mario-campos/node24'.

nothing to commit, working tree clean

@mbg
Copy link
Member

mbg commented Oct 3, 2025

@mario-campos Have you run git fetch origin and then attempted git merge origin/main? I'd expect the merge conflicts to show up then.

# Conflicts:
#	lib/analyze-action-post.js
#	lib/analyze-action.js
#	lib/autobuild-action.js
#	lib/init-action-post.js
#	lib/init-action.js
#	lib/resolve-environment-action.js
#	lib/start-proxy-action-post.js
#	lib/start-proxy-action.js
#	lib/upload-lib.js
#	lib/upload-sarif-action-post.js
#	lib/upload-sarif-action.js
#	package-lock.json
#	package.json
@mario-campos mario-campos dismissed stale reviews from henrymercer and mbg via b2e2232 October 3, 2025 17:59
@henrymercer
Copy link
Contributor

I think we're good to update the required checks (see these instructions) and kick off a release.

Once the v4 release is merged, the release automation should open a backport from v4 to v3. That backport will bring in all the changes from v4, including the bump to node24 in the action.ymls. At that point we'll need to push a commit to the releases/v3 branch that moves the Actions back to node20.

@mario-campos mario-campos merged commit 5528384 into main Oct 6, 2025
245 of 246 checks passed
@mario-campos mario-campos deleted the mario-campos/node24 branch October 6, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants