Skip to content

Conversation

@jaxn
Copy link
Contributor

@jaxn jaxn commented Dec 11, 2025

jest is not supported with vite.

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, or chat mode file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, or chat mode with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.

Description


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New chat mode file.
  • New collection file.
  • Update to existing instruction, prompt, chat mode, or collection.
  • Other (please specify):

Additional Notes

The Vue3 instructions suggest using Jest with Vite, which is not officially supported by jest and is inconsistent with the other guidelines in the file.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Copilot AI review requested due to automatic review settings December 11, 2025 19:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the testing framework recommendation in the Vue 3 instructions file from Jest to Vitest. Since Vue 3 projects typically use Vite as the build tool (as specified in line 14 of the same file), Vitest is the appropriate testing framework choice due to its native integration with Vite. Jest does not have official Vite support, making this change both technically accurate and consistent with other Vite-based framework instructions in the repository.

Key Changes:

  • Updated testing section to recommend Vitest instead of Jest for unit testing with Vue Test Utils

@aaronpowell aaronpowell merged commit ac93f98 into github:main Dec 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants