Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds proper grammar for the DM language. #2928

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Conversation

PJB3005
Copy link
Contributor

@PJB3005 PJB3005 commented Apr 1, 2016

The DM language has been in Linguist for a long time, but always used the C++ lexer.

@seiyria

@pchaigno
Copy link
Contributor

pchaigno commented Apr 1, 2016

The grammar is missing a license ;)
Could you also show the improvement, using Lightshow, on this DM sample (or any other sample)?

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 1, 2016

Alright amended to add a license, gonna work on showing the difference.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 1, 2016

Uhm, Lightshow is giving me the following error when trying to use it:
Error parsing YAML grammar: (<unknown>): did not find expected ',' or ']' while parsing a flow sequence at line 1 column 12

The grammar is an Atom CSON grammar but it's seeing it as YAML for some reason.

@pchaigno
Copy link
Contributor

pchaigno commented Apr 1, 2016

@PJB3005 See #2924 ;)

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 1, 2016

Alright I'll update the grammar to add quotes for Lightshow, then.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 1, 2016

Before

After

@arfon arfon merged commit 5e3e813 into github-linguist:master Apr 3, 2016
@arfon
Copy link
Contributor

arfon commented Apr 3, 2016

Thanks for this contribution @PJB3005 ⚡. This will be live in the next release of Linguist (likely sometime in the next week).

@duncathan
Copy link

Oh this is lovely

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants