Fetch GitHub Team name for Classroom Assistant #1727
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
ghost
requested a review
from 
|
@srinjoym Is this still WIP? Should we close it? |
| @@ -6,7 +6,7 @@ class GroupAssignmentRepoSerializer < ActiveModel::Serializer | |||
| attributes :displayName | |||
|
|
|||
| def username | |||
| object.group.title | |||
| object.group.github_team.name | |||
There was a problem hiding this comment.
I'm trying to understand the implications of fetching from the API here; If I am understanding correctly we fetch from the API every time we access the github_* properties. This means every time we serialize a GroupAssignmentRepo to JSON we will hit the github API. The main place this feels problematic is here: https://github.com/education/classroom/blob/8be229a98e7a56b808e977472c46d48b2d62c2ce/app/controllers/api/group_assignment_repos_controller.rb#L11-L12
This introduces and github API N+1 if I am reading this right. I'm not clear if that is acceptable.
There was a problem hiding this comment.
Depending on our setup, I think OctoKit would cache these at the client level?
There was a problem hiding this comment.
Octokit should cache them, correct
Fetch the team name from GitHub everytime we serialize a group assignment repo. This fixes github-education-resources/classroom-assistant#117