Skip to content

Refactor 404 handling #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
decyjphr merged 1 commit into from
Sep 26, 2025
Merged

Refactor 404 handling #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/plugins/archive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = class Archive {
})
return data
} catch (error) {
if (error.status === 404 && !this.getDesiredArchiveState()) {
if (error.status === 404) {
return null

Copilot AI Sep 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the !this.getDesiredArchiveState() condition changes the behavior for 404 errors. This now returns null for all 404 errors regardless of the desired archive state, which may not be the intended behavior. Consider documenting why this condition was removed or verify this change doesn't break existing functionality.

Suggested change
return null
if (!this.getDesiredArchiveState()) {
return null
}

Copilot uses AI. Check for mistakes.

@decyjphr decyjphr Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the repo is not existing, whether to archive or unArchive doesn't make much of a difference. We cannot throw an Error and stop further processing.

}
throw error
Expand Down Expand Up @@ -59,13 +59,13 @@ module.exports = class Archive {
shouldArchive (repository = this.repository) {
const desiredState = this.getDesiredArchiveState()
if (desiredState === null) return false
return !repository.archived && desiredState
return !repository?.archived && desiredState
}

shouldUnarchive (repository = this.repository) {
const desiredState = this.getDesiredArchiveState()
if (desiredState === null) return false
return repository.archived && !desiredState
return repository?.archived && !desiredState
}

isArchived () {
Expand Down