build(deps): bump js-yaml, qs, shell-quote (incorporate PR #1001) - #1050
Merged
Conversation
PR #1001 (dependabot npm_and_yarn group) bumped js-yaml 4.1.1->4.2.0, qs 6.15.0->6.15.2, and shell-quote 1.8.3->1.8.4. These were not yet present in this branch. Rather than merging the dependabot merge commit (baac44d) — which pulls in the entire divergent pre-probot-14.3.2 tree and conflicts massively — the updates were applied surgically via `npm update` against the current probot 14.3.2 lockfile, resolving to equal-or-newer semver-compatible versions that fully cover PR #1001: js-yaml 4.1.1 -> 4.3.1 qs 6.15.0 -> 6.15.3 shell-quote 1.8.3 -> 1.10.0 plus related transitive bumps (js-yaml 3.14.2->3.15.1, side-channel). Validated: unit/integration suite (344 passing; the 7 probot-ESM/Jest suites fail pre-existing from the probot 14.3.2 migration, unrelated), lockfile-lint clean, npm ls clean, and full live smoke-test (181 pass). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot PR #1001 (merge commit
baac44d, npm_and_yarn group) bumped three packages to pick up security/patch fixes:js-yaml4.1.1 -> 4.2.0,qs6.15.0 -> 6.15.2, andshell-quote1.8.3 -> 1.8.4. Those bumps had not yet landed onyadhav/fix-recent-issues(which has since moved to probot 14.3.2), so they still needed to be brought in.Approach
Merging the Dependabot merge commit directly was not viable:
baac44ddrags in the entire pre-probot-14.3.2 divergent tree and conflicts across ~20 files that have nothing to do with the dependency bump. Instead, the three updates were applied surgically withnpm update js-yaml qs shell-quoteagainst the current probot 14.3.2 lockfile. npm resolved them to equal-or-newer semver-compatible versions that fully cover (and supersede) PR #1001:js-yaml4.1.1 -> 4.3.1qs6.15.0 -> 6.15.3shell-quote1.8.3 -> 1.10.0plus the related transitive bumps npm pulled in for consistency (
js-yaml3.14.2 -> 3.15.1,side-channel/side-channel-list). Onlypackage-lock.jsonchanged;js-yaml's^4.1.0range inpackage.jsonalready permits 4.3.1, so no manifest change was needed.Validation
lint:lockfileclean,npm lsclean.ghPAT lacksadmin:orgscope for drift injection, and theghas-complianceapp is an enterprise installation without repo permissions). None stem from the dependency change.Note for reviewers
Tests must be run under Node 22 (
lint:enginesand the probot 14.3.2 runtime require Node >= 22; Node 21 fails to load the now-ESM probot).