Skip to content

Fix an issue where in some cases 'wrong' commits are shown in listed branches #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krlvi
Copy link
Member

@krlvi krlvi commented Apr 2, 2025

This was because the merge base computed was wrong. Instead of relying on the default target.sha, which may have become stale, read the git reference of the default target

Edit: seems not that simple, parking this for now

Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:05am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:05am

krlvi added 2 commits April 2, 2025 10:29
…branches

This was because the merge base computed was wrong. Instead of relying on the default target.sha, which may have become stale, read the git reference of the default target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant