Merged
Conversation
The nested-loop matching in normalizeLicenseWords is O(n^2) in the number of words. A ~3 KB input string with many words can pin a CPU core for minutes. Rejects inputs with more than 256 words, which is far beyond any real SPDX expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nested-loop matching in `normalizeLicenseWords` tries progressively shorter word spans from each position, giving O(n^2) behavior in the number of words. A ~3 KB string can pin a CPU core for minutes.
Adds a 256-word cap at the top of the function. No real SPDX expression comes close to this limit.