I18n #146

m0rp30 · 2022-08-19T15:26:46Z

#18 #129 @schokotets @blinry

Ok guys i have refactoring the localization system, and for me it's came out very well.

I following your suggestions, i have concentrade all traduction files in the "locale" folder.

I have make three template files:

cards.pot -> All descriptions of the cards
levels.pot -> All the titles, descriptions, congrats and other of the levels
text.pot -> All text you can find in the scenes

Requirement

gettext
po editor (I used poedit)

Process

Generate .po file in your localization (es. es_ES-text.po ) with template files (.pot)
Upload the files on Project -> Project settings -> Localization at Godot
Add an item to the dictionary "languages" at the file game.gd (es. var languages = {"en": tr("English"), "it": tr("Italian"), "es": tr(Spanish)} # Localizations allowed
Make traduction

What do you think?!?!

…evels

…and labels

… the localizations of levels and cards

localization: refining italian translation. part 1

localization: refine italian translation. part 2

Co-authored-by: schokotets <[email protected]>

…tion of the first level was added

schokotets · 2022-08-20T18:12:34Z

scenes/levels.gd

@@ -3,14 +3,14 @@ extends Node
 var chapters

 func _ready():
-	var lang = game.lang
+	var lang = game.os_lang


just wondering: what is the variable lang used for?

sorry ... my mistake!!!

excuse me i don't have sync last commit in pull request! Now all is sync.

schokotets · 2022-08-20T18:21:01Z

levels/branches/checkout-commit

@@ -3,7 +3,7 @@ cards = checkout commit-auto

 [description]

-The yellow boxes are frozen points in time, we call them "commits"! You can travel between them using the "checkout" card! (Try it!)
+The yellow boxes are frozen points in time, we call them 'commits'! You can travel between them using the "checkout" card! (Try it!)


why is only a pair of double quotes changed to singe ones?

In .po files, the msgid is wrap in double quotes and the string must match perfectly

In this case i have changed manually that string for test but in the script i have add code to replace the double quote in single quote

oliveirafilipe · 2022-08-29T23:18:35Z

Just a matter of organization:

What if each language´s files was inside a folder of its own?

locale folder could get huge with 3 files for each possible language.
For example:

$ pwd
./oh-my-git/locale

$ ls -R
.:
babelrc  cards.pot  it_IT/  levels.pot  pt_BR/  text.pot

./it_IT:
it_IT-cards.po  it_IT-levels.po  it_IT-text.po

./pt_BR:
pt_BR-cards.po  pt_BR-levels.po  pt_BR-text.po

oliveirafilipe · 2022-08-29T23:40:19Z

Some other thoughts:

Maybe the "Language" button should always be in English, or at least contain the "Language" word, for example: "Linguaggio/Language", because I can end up in a language I don't know without being able to go back to English because I can't read which button would do that.
I can't find the reason right now, but no alphabet other than Latin seems to be working (i.e: Cyrillic, Slavic, Chinese)

m0rp30 · 2022-08-31T06:43:00Z

It's a good idea !!!

…alizations as suggested in the post git-learning-game#146 (comment)

m0rp30 · 2022-08-31T08:41:31Z

Some other thoughts:

Maybe the "Language" button should always be in English, or at least contain the "Language" word, for example: "Linguaggio/Language", because I can end up in a language I don't know without being able to go back to English because I can't read which button would do that.

I can't find the reason right now, but no alphabet other than Latin seems to be working (i.e: Cyrillic, Slavic, Chinese)

It's a way, but for me it's also nice to translate it
The reason it's the fonts but i don't really sure how to fix it

schokotets · 2022-09-08T08:28:50Z

Hello @m0rp30, thanks again for your willingness to contribute! It is outstanding how quickly you've continued to take feedback and work on your contribution, and how much effort you're putting into it. As stated before, i18n plays a big role in making the game accessible to a larger audience, so your contributions are so valuable!

Sorry for getting back to you so late, I haven't had the time to review it thoroughly so far, so I'll stay brief for this comment.
I like the way you've realized translating cards & texts! It's great to use the .po format, it integrates nicely with existing tooling and Godot's translation mechanisms. I'd like to discuss the folder structure and file naming at a later point.

Concerning the levels: I've discussed the structure of internationalizing the levels themselves again with @blinry . We would like to stick to our suggestion of not using the .po format with extracted strings, but instead having multiple copies of the levels' files for the different languages. We want to pursue this approach because we think that we should prioritize quality and completeness of translation. For this, we want translators to be able to change the git commands and file names, and perhaps even the amount and kinds of files available, to be able to translate as much of the level as possible and to allow adaptation for cultural appropriateness. We would not see this realized fully if we extracted strings from the level files.

Can you agree with our prioritization and follow our conclusions? If so, please rework your pull request to eliminate the *levels.po files and instead, in each level's folder, have a folder for the level's part, and in it a file for each language. For example. the merge level:

merge (directory)
├── conflict (directory)
│   └── en (file)
├── merge (directory)
│   └── en (file)
├── merge-abort (directory)
│   └── en (file)
└── sequence (file)

3 directories, 4 files

blinry · 2022-09-08T08:37:51Z

I also wanted to chime in with huge thanks to both @m0rp30 for working on this PR, as well as @schokotets for making sure that the translation feature will be as good as it can be! 💚

blinry · 2022-09-08T08:41:55Z

@oliveirafilipe I like your idea that the language switching button should always include both the label "English", as well as the native language, that would be perfect.

And the problem with the missing characters is likely that our font Cabin, doesn't include Cyrillic/Slavic/Chinese glyphs. We would need to look for a fallback font for those languages.

m0rp30 · 2022-09-13T11:44:19Z

Hello @m0rp30, thanks again for your willingness to contribute! It is outstanding how quickly you've continued to take feedback and work on your contribution, and how much effort you're putting into it. As stated before, i18n plays a big role in making the game accessible to a larger audience, so your contributions are so valuable!

Sorry for getting back to you so late, I haven't had the time to review it thoroughly so far, so I'll stay brief for this comment. I like the way you've realized translating cards & texts! It's great to use the .po format, it integrates nicely with existing tooling and Godot's translation mechanisms. I'd like to discuss the folder structure and file naming at a later point.

Concerning the levels: I've discussed the structure of internationalizing the levels themselves again with @blinry . We would like to stick to our suggestion of not using the .po format with extracted strings, but instead having multiple copies of the levels' files for the different languages. We want to pursue this approach because we think that we should prioritize quality and completeness of translation. For this, we want translators to be able to change the git commands and file names, and perhaps even the amount and kinds of files available, to be able to translate as much of the level as possible and to allow adaptation for cultural appropriateness. We would not see this realized fully if we extracted strings from the level files.

Can you agree with our prioritization and follow our conclusions? If so, please rework your pull request to eliminate the *levels.po files and instead, in each level's folder, have a folder for the level's part, and in it a file for each language. For example. the merge level:
merge (directory)
├── conflict (directory)
│   └── en (file)
├── merge (directory)
│   └── en (file)
├── merge-abort (directory)
│   └── en (file)
└── sequence (file)

3 directories, 4 files

sorry if I answer only now, I didn't understand the hint for the levels, i will immediately proceeded to change the system for the levels and do the merge

…s and made some changes to the scripts

m0rp30 · 2022-09-13T12:43:29Z

OK, now the system and italian traduction it's ok, the levels have a specific directory with translated files and the other strings have .po file for the traductions

oliveirafilipe · 2022-09-13T13:47:48Z

Hi @m0rp30, just to point out, I think your solution its slightly different from the proposed by @schokotets, but I think both of them work nicely.

m0rp30 · 2022-09-13T14:46:51Z

Hi @m0rp30, just to point out, I think your solution its slightly different from the proposed by @schokotets, but I think both of them work nicely.

Ok ... now I understand ... I'm a bit brainless 😄 but I have some questions:

What level do we show if the translation is not finished (if we show it!)
If one or more languages have more levels than the original (English), we heve to make the English version also
For me, it's a bit more complicated to track the point of the traduction
My system it's more easy to make

I can make an other pull request with the @schokotets's system and test it !!!

@blinry and @schokotets what do you think ?

schokotets · 2022-09-26T22:39:22Z

Hi @m0rp30 , glad you got to implementation so quickly, It's a shame I haven't seen your message earlier.

The thought behind the proposed folder structure was the following: make it as hard as possible to deviate from the given structure (which parts a level contains) in different translations. This assumes that we'd want to enforce keeping the different levels' translations in the same structure — is that right, @blinry ?

I try to expand the proposed folder structure by the Italian translation to explain it better.

merge (directory)
├── conflict (directory)
│   ├── en (file containing the "conflict" part of the "merge" level in English)
│   └── it (file containing the "conflict" part of the "merge" level in Italian)
├── merge (directory)
│   ├── en (file containing the "merge" part of the "merge" level in English)
│   └── it (file containing the "merge" part of the "merge" level in Italian)
├── merge-abort (directory)
│   ├── en (file containing the "merge-abort" part of the "merge" level in English)
│   └── it (file containing the "merge-abort" part of the "merge" level in Italian)
└── sequence (file containing the sequence of the level parts)

Also, the motivation behind keeping the custom level format was to allow translation of the multiple "virtual file"s' names in each level. E.g. in levels/it/index/steps (referencing your file structure), the bottle file could be called bottiglia (if my assumption about Italian is correct).

@blinry and I see find it valuable to provide the freedom of varying the shell scripts. This includes file names, as described in the previous paragraph. Furthermore, what needs to be done precisely for each level could be changed to be more culturally appropriate. E.g. instead of having two files knife and fork, it could be a single file chopsticks. Or varying the task, e.g. not taking the bus to disco, but inviting family for a dance, and whatever changes in script this procures. While this may not find application in the current state of the project, we'd like to provide the opportunity for adaptations of this kind.

Having a .po file structure is problematic, in our eyes: it would harden the level's internal phrasing and leave less room to adapt. It would nudge translators towards literal translation, instead of rewriting little stories in the level parts.

To address your questions and concerns:

What level do we show if the translation is not finished (if we show it!)

The easiest would be to show the English version. However, this is not ideal, because English might not be the player's next best language. Therefore, I'd suggest offering a language picker dialog every time this happens to select a fallback language.

If one or more languages have more levels than the original (English), we heve to make the English version also

I believe that's not the case, as my proposed folder structure doesn't really enforce an 'original' language. New levels could start out in other languages.

For me, it's a bit more complicated to track the point of the traduction
My system it's more easy to make

I see, this is the disadvantage of deviating from using the .po file format and tooling. However, @blinry and I find it a worthwhile discomfort, because it enables better, more adaptable translation, as explained further up.

Can you follow our argumentation, do you agree? We could also discuss the details here, if you'd like, before having to do it one way and then un-doing too much which one could've been spared of.

Thanks for keeping to work on this, I'm so happy to see it come together so nicely :)

m0rp30 · 2022-10-05T09:47:03Z

Ok, I made another pull request #152 where I created the layer structure as suggested by @schokotets.

I hope it' fine 😄

m0rp30 and others added 30 commits September 6, 2021 12:25

Upgrade gitignore

9431266

Add split description in italia and english and add directory it in l…

2c27542

…evels

Add italian localizations and mechanism for card, levels and buttons …

705cc84

…and labels

finished the mechanism for setting the language

50ee071

add org file in gitignore

d7b40c5

add emacs backup files

14e753a

traductions of the levels

331f08b

some levels translated

6857781

some traductions

5488edc

cards localization adjustament

1dcde88

now is right the card_draw

f98922c

some traductions

9057421

add some localizations and levels traductions

086922d

Code refactor and adding, in the README file, the instructions to add…

216db5c

… the localizations of levels and cards

README file adjustaments

2f1ff72

README file some adjustaments

6fb0f72

README file some adjustaments

9db0d09

README file now its ok :)

b54abd2

some adjustaments and code refactor

f8530a5

export configurations file

42ebe9e

Adding another line for the explanation of localization mechanism

b9fc323

Some levels translations

6e0661b

localization: refining italian translation. part 1

91ad509

Merge pull request #1 from morrolinux/main

942dff7

localization: refining italian translation. part 1

refining italian translation part 2

93b2a72

Merge branch 'm0rp30:main' into main

ab6dcd8

various bugfixes

e57dfca

Merge branch 'main' of github.com:morrolinux/oh-my-git

6328fe7

Merge pull request #2 from morrolinux/main

1bf845c

localization: refine italian translation. part 2

Update scenes/repository.gd

d8e649d

Co-authored-by: schokotets <[email protected]>

m0rp30 added 5 commits August 18, 2022 22:55

Some modification .po files

27db39c

Add *.mo files to gitignore

4ef05f6

the internationalization system was completed and the Italian transla…

337d3d3

…tion of the first level was added

Add template files for generating .po file in other languages

ba3e4b0

change files .po names

ba53de0

schokotets mentioned this pull request Aug 20, 2022

Added the localization mechanism for levels and cards #129

Closed

schokotets reviewed Aug 20, 2022

View reviewed changes

m0rp30 added 4 commits August 21, 2022 09:03

Merge branch 'git-learning-game:main' into i18n

6a4d98a

Adding renamed file .po

2616c8b

some traductions

9da07de

Some translations

5b28efc

m0rp30 added 2 commits August 31, 2022 08:44

Presets upgrade

8cb71aa

organized the local folder into subfolders containing the various loc…

e802402

…alizations as suggested in the post git-learning-game#146 (comment)

deleted the .po level files and added dir italian levels in dir level…

af776bd

…s and made some changes to the scripts

Some adjustaments

9caaddc

m0rp30 closed this Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I18n #146

I18n #146

m0rp30 commented Aug 19, 2022

schokotets Aug 20, 2022

m0rp30 Aug 20, 2022

m0rp30 Aug 21, 2022

schokotets Aug 20, 2022

m0rp30 Aug 20, 2022

m0rp30 Aug 20, 2022

oliveirafilipe commented Aug 29, 2022 •

edited

Loading

oliveirafilipe commented Aug 29, 2022 •

edited

Loading

m0rp30 commented Aug 31, 2022

m0rp30 commented Aug 31, 2022

schokotets commented Sep 8, 2022 •

edited

Loading

blinry commented Sep 8, 2022

blinry commented Sep 8, 2022

m0rp30 commented Sep 13, 2022

m0rp30 commented Sep 13, 2022 •

edited

Loading

oliveirafilipe commented Sep 13, 2022

m0rp30 commented Sep 13, 2022

schokotets commented Sep 26, 2022

m0rp30 commented Oct 5, 2022

I18n #146

I18n #146

Conversation

m0rp30 commented Aug 19, 2022

schokotets Aug 20, 2022

Choose a reason for hiding this comment

m0rp30 Aug 20, 2022

Choose a reason for hiding this comment

m0rp30 Aug 21, 2022

Choose a reason for hiding this comment

schokotets Aug 20, 2022

Choose a reason for hiding this comment

m0rp30 Aug 20, 2022

Choose a reason for hiding this comment

m0rp30 Aug 20, 2022

Choose a reason for hiding this comment

oliveirafilipe commented Aug 29, 2022 • edited Loading

oliveirafilipe commented Aug 29, 2022 • edited Loading

m0rp30 commented Aug 31, 2022

m0rp30 commented Aug 31, 2022

schokotets commented Sep 8, 2022 • edited Loading

blinry commented Sep 8, 2022

blinry commented Sep 8, 2022

m0rp30 commented Sep 13, 2022

m0rp30 commented Sep 13, 2022 • edited Loading

oliveirafilipe commented Sep 13, 2022

m0rp30 commented Sep 13, 2022

schokotets commented Sep 26, 2022

m0rp30 commented Oct 5, 2022

oliveirafilipe commented Aug 29, 2022 •

edited

Loading

oliveirafilipe commented Aug 29, 2022 •

edited

Loading

schokotets commented Sep 8, 2022 •

edited

Loading

m0rp30 commented Sep 13, 2022 •

edited

Loading