Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forum post component #197

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

priyanshisharma
Copy link
Contributor

Fixes #190

Description

Created a forum post component according to the figma design as per the scss module approach i.e. currently in use.

Screenshots

Web View

Screen Shot 2021-02-03 at 12 05 58 PM

Mobile View

Screen Shot 2021-02-03 at 12 05 44 PM

Addition Information (if any)

The horizontal line doesn't span across the entire width, when the component is used in a wider space.
Screen Shot 2021-02-03 at 12 06 11 PM

@salil-naik
Copy link
Contributor

Hi @priyanshisharma. Good job with the component. It's around 70% pixel perfect.

I saw a few errors in the way the markup is structured. Please refer to the image below. It will give you an idea of how things should be divided.

Blue/Orange blocks are the man blocks. Red are the inner divisions.

If you refer to the Figma design, you will see that we have used auto-layout (similar to display flex) in the main blocks. So in the first block, the padding will be 20px, gutter space (space b/w the red blocks) is going to be 17px. The horizontal line can be the border-bottom of the first block.

If you fix your markup, you won't have to use <br /> tags anywhere. It's not a good practice to use <br /> tags for spacing btw.

Forum-Post (1)

Copy link
Contributor

@salil-naik salil-naik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Please refer to the comment and do the necessary changes. 😄

@priyanshisharma
Copy link
Contributor Author

Thanks for such a well written review @salil-naik ! I've made the corresponding changes, the component appears as follows now. 😄
Screenshot 2021-02-12 at 1 11 14 AM

@pkspyder007
Copy link
Collaborator

@priyanshisharma Could you just add the component to /forum route so it could be viewed in the browser in the buil preview?

@pkspyder007
Copy link
Collaborator

pkspyder007 commented Mar 29, 2021

@priyanshisharma I think the reason why these icons are not looking good is that they are small resolution images taken from figma design. Replacing them will svg icons would be a better solution so they don't get pixelated.

Both the icons social and action ones.

@priyanshisharma
Copy link
Contributor Author

@pkspyder007 where can I get the svg files for the action buttons from? 😅

@pkspyder007
Copy link
Collaborator

@priyanshisharma check out this site https://feathericons.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Forum Post Component
3 participants