-
Notifications
You must be signed in to change notification settings - Fork 3
TextDB can walk up directory trees #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
with this option True, paths in the validity file are allowed to contain '..', exiting the current directory tree boundary. Needed e.g. for legend-dataprod-overrides.
|
@gipert: What do you think? |
|
well trying to access something that lies outside the database doesn't make a lot of sense to me, can't you just fix by using as root path a folder that contains all the data you are interested in? |
|
That also does not make a lot of sense to me either, but that's how legend-dataprod-overrides currently looks like. So I only see three options:
|
|
On the overrides, maybe could symlink things? not the most pleasant but might be easiest |
|
potentially I could also modify things on the dataflow side to handle this better which might be the nicest solution |
|
@ggmarshall I think this would be good. I strongly prefer this to implementing hacks in TextDB. In general the overrides repository is a mess and we should refactor it as we already discussed... |
@schwarzmario I would still like to have this in since it's a bug fix... |
|
Sure I'll cherrypick the fix. I prefer a solution, where one can still use TextDB (or similar) stand-alone on the overrides. I currently use this to verify if SiPM calibrations still apply for later runs (otherwise, I would have to manually add all overwrite files...). |
|
here you are: #40 |
Currently, TextDB cannot walk up directory trees, i.e. fails when a validity.yaml contains things like
which exist in legend-dataprod-overrides (e.g. in https://github.com/legend-exp/legend-dataflow-overrides/blob/main/hit/validity.yaml).
I added a init argument
allow_up_tree(default toFalse), which allows to traverse directory trees upwards, out of the current directory.I also made the
hiddenparameter be passed to sub-directories.