Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Ionic Analytics #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ejwill
Copy link

@ejwill ejwill commented Jun 20, 2015

integrated ionic.io analytics http://docs.ionic.io/v1.0/docs/deploy-from-scratch.

side note saw that you created ionic-parse-facebook-auth are you going to integrate that in this repo?

@ejwill
Copy link
Author

ejwill commented Jun 21, 2015

I was following the example Ionic created here https://github.com/driftyco/ionic-starter-analytics/blob/master/js/app.js

@giorgiofellipe
Copy link
Owner

Could you merge the duplicated .config and .run functions?
Like this:

.run(['$ionicPlatform', '$ionicAnalytics', function($ionicPlatform, $ionicAnalytics) {
  //go to https://github.com/driftyco/ionic-starter-analytics to see another example
  //analytics docs http://docs.ionic.io/v1.0/docs/analytics-from-scratch
  $ionicAnalytics.register();

  $ionicPlatform.ready(function() {
    // Hide the accessory bar by default (remove this to show the accessory bar above the keyboard
    // for form inputs)
    if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
      cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
    }
    if (window.StatusBar) {
      // org.apache.cordova.statusbar required
      StatusBar.styleLightContent();
    }
  });
}])

@ejwill ejwill changed the title Added Ionic Analytics Feature/Ionic Analytics Jun 21, 2015
@ejwill
Copy link
Author

ejwill commented Jun 21, 2015

Updated to combine .run and .config . So are you going to fold in User management from ionic-parse-facebook-auth?

@giorgiofellipe
Copy link
Owner

Seems better now, I'll take a look later and merge asap. Thank you!

About the auth: ye, but I'm so busy these days. If you need it sooner feel free to implement and ask me for help, if needed.

@giorgiofellipe
Copy link
Owner

I was wondering if makes sense to use Ionic Analytics instead of using Parse Analytics.
Indeed it is a Ionic app boilerplate, but its intention is help users to easily build with Parse using all of their services.
What do you think about it @ejwill?

@ejwill
Copy link
Author

ejwill commented Jun 26, 2015

@giorgiofellipe both are good options. Ionic Analytics along with the other Ionic services are going to play better with the Ionic framework than anything else. I know some analytic services are tripped up by the use of angular in Ionic. I have not done any research into Parse analytics to know if it has a problem with Angular or not. Another, thing to remember is we don't know what the pricing on the Ionic services are yet. They are free during beta tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants