Add transform_iterator #1836
Add transform_iterator #1836
Conversation
ginkgo-bot
added
reg:testing
upsj
force-pushed
the
transform_iterator
branch
from
360872b to
32068ed
Compare
| auto test_iter = gko::detail::make_transform_iterator<TypeParam*>( | ||
| nullptr, [](TypeParam v) { return v; }); | ||
|
|
||
| ASSERT_NO_THROW((void)std::find(test_iter, test_iter, TypeParam{})); |
There was a problem hiding this comment.
does it check anything? std::find does not do anything because first and end are the same.
also what is (void) for?
There was a problem hiding this comment.
No, this is just a copy of the same test for permute_iterator. I needed to use a read-only operation, so find was the first thing that came to mind. The (void) is there to silence the [[nodiscard]] warning.
upsj
force-pushed
the
transform_iterator
branch
from
32068ed to
34f6a8c
Compare
upsj
force-pushed
the
transform_iterator
branch
from
34f6a8c to
a94c5a8
Compare
There was a problem hiding this comment.
LGTM from the implementation, but I am not familiar with the iterator implementation.
If someone can review it to check whether it match the std iterator requirement or you can give the reference. I only check the iterator_traits and the random access iterator requirement.
I assume it will just give a compilation error when the Iterator is not random accessable because the following member functions uses the iterator as random access iterator.
| TYPED_TEST(TransformIterator, IncreasingIterator) | ||
| { | ||
| std::vector<TypeParam> vec{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; | ||
| auto transform = double_transform{}; |
There was a problem hiding this comment.
The following two tests do not check the value after transformation, so I think use scale_transofrm should be good enough
This adds a transform_iterator that can be used with standard library algorithms and other functions like the ones from #1820