IPC 717 Refactor Payment Review Screen for not recreating after orientation change

.github/workflows/bank-api-library.check.yml

@@ -72,7 +72,7 @@ jobs:
           script: >
             adb uninstall net.gini.android.bank.api.test ;
             ./gradlew bank-api-library:library:connectedCheck
-            -PtestClientId="gini-mobile-test"
+            -PtestClientId="gini-mobile-ci"
             -PtestClientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
             -PtestApiUri="https://pay-api.gini.net"
             -PtestUserCenterUri="https://user.gini.net"

.github/workflows/bank-sdk.check.yml

@@ -108,7 +108,7 @@ jobs:
           script: >
             adb uninstall net.gini.android.bank.sdk.test ;
             ./gradlew bank-sdk:sdk:connectedCheck
-            -PtestClientId="gini-mobile-test"
+            -PtestClientId="gini-mobile-ci"
             -PtestClientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
             -PtestApiUri="https://pay-api.gini.net"
             -PtestUserCenterUri="https://user.gini.net"
@@ -132,7 +132,7 @@ jobs:
           script: >
             adb uninstall net.gini.android.bank.sdk.exampleapp.test ;
             ./gradlew bank-sdk:example-app:connectedDevExampleAppDebugAndroidTest
-            -PclientId="gini-mobile-test"
+            -PclientId="gini-mobile-ci"
             -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
 
       - name: archive instrumented test results
@@ -157,7 +157,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew bank-sdk:example-app:assembleQaExampleAppRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="screen_api_example.jks"
           -PreleaseKeystorePassword='${{ secrets.BANK_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'
@@ -173,7 +173,7 @@ jobs:
       - name: build release example app for production
         run: >
           ./gradlew bank-sdk:example-app:assembleProdExampleAppRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="screen_api_example.jks"
           -PreleaseKeystorePassword='${{ secrets.BANK_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/bank-sdk.publish.firebase.example.yml

@@ -47,7 +47,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew bank-sdk:example-app:assembleQaExampleAppRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="screen_api_example.jks"
           -PreleaseKeystorePassword='${{ secrets.BANK_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/capture-sdk.check.yml

@@ -203,7 +203,7 @@ jobs:
           script: >
             adb uninstall net.gini.android.capture.network.test ;
             ./gradlew capture-sdk:default-network:connectedCheck
-            -PtestClientId="gini-mobile-test"
+            -PtestClientId="gini-mobile-ci"
             -PtestClientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
             -PtestApiUri="https://pay-api.gini.net"
             -PtestUserCenterUri="https://user.gini.net"

.github/workflows/gpc.publish.firebase.example.yml

@@ -32,7 +32,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew bank-sdk:example-app:assembleQaPaymentProvider3Release
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="screen_api_example.jks"
           -PreleaseKeystorePassword='${{ secrets.BANK_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/health-api-library.check.yml

@@ -118,7 +118,7 @@ jobs:
           script: >
             adb uninstall net.gini.android.health.api.test ;
             ./gradlew -Pandroid.testInstrumentationRunnerArguments.apiEnv=${{ inputs.healthApiEnvironment }} health-api-library:library:connectedCheck
-            -PtestClientId='gini-mobile-test'
+            -PtestClientId='gini-mobile-ci'
             -PtestClientSecret='${{ inputs.healthApiEnvironment == 'staging' && secrets.STAGING_GINI_MOBILE_TEST_CLIENT_SECRET || secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}'
             -PtestApiUri='${{ inputs.healthApiEnvironment == 'staging' && 'https://health-api.stage.gini.net' || 'https://health-api.gini.net' }}'
             -PtestUserCenterUri='${{ inputs.healthApiEnvironment == 'staging' && 'https://user.stage.gini.net' || 'https://user.gini.net' }}'

.github/workflows/health-sdk.check.yml

@@ -59,7 +59,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew health-sdk:example-app:assembleQaRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="health_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.HEALTH_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'
@@ -75,7 +75,7 @@ jobs:
       - name: build release example app for production
         run: >
           ./gradlew health-sdk:example-app:assembleProdRelease 
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="health_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.HEALTH_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/health-sdk.publish.firebase.example.yml

@@ -46,7 +46,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew health-sdk:example-app:assembleQaRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="health_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.HEALTH_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/merchant-sdk.check.yml

@@ -60,7 +60,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew merchant-sdk:example-app:assembleQaRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="merchant_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.MERCHANT_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'
@@ -76,7 +76,7 @@ jobs:
       - name: build release example app for production
         run: >
           ./gradlew merchant-sdk:example-app:assembleProdRelease 
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="merchant_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.MERCHANT_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

.github/workflows/merchant-sdk.publish.firebase.example.yml

@@ -46,7 +46,7 @@ jobs:
       - name: build release example app for QA
         run: >
           ./gradlew merchant-sdk:example-app:assembleQaRelease
-          -PclientId="gini-mobile-test" 
+          -PclientId="gini-mobile-ci" 
           -PclientSecret="${{ secrets.GINI_MOBILE_TEST_CLIENT_SECRET }}"
           -PreleaseKeystoreFile="merchant_sdk_example.jks"
           -PreleaseKeystorePassword='${{ secrets.MERCHANT_SDK_EXAMPLE_APP_KEYSTORE_PASSWORD }}'

bank-api-library/library/src/androidTest/assets/result_Gini_invoice_example.json

@@ -1,127 +1,161 @@
 {
   "extractions": {
+    "docType": {
+      "entity": "doctype",
+      "value": "Invoice"
+    },
+    "amountToPay": {
+      "entity": "amount",
+      "value": "995.00:EUR",
+      "candidates": "amounts"
+    },
     "paymentRecipient": {
       "entity": "companyname",
       "value": "Fahrrad Rückenwind",
+      "box": {
+        "top": 446.55,
+        "left": 280.55,
+        "width": 432.99999999999994,
+        "height": 39.0,
+        "page": 1
+      },
       "candidates": "paymentRecipients"
     },
+    "paymentState": {
+      "entity": "paymentstate",
+      "value": "ToBePaid"
+    },
+    "instantPayment": {
+      "entity": "text",
+      "value": "false"
+    },
     "paymentPurpose": {
-      "entity": "reference",
+      "entity": "text",
       "value": "RE-20210512-02"
     },
     "bic": {
       "entity": "bic",
       "value": "BYLADEM1001",
+      "box": {
+        "top": 2690.5,
+        "left": 280.5,
+        "width": 350.0,
+        "height": 35.0,
+        "page": 1
+      },
       "candidates": "bics"
     },
-    "amountToPay": {
-      "entity": "amount",
-      "value": "995.00:EUR",
-      "candidates": "amounts"
-    },
     "iban": {
       "entity": "iban",
       "value": "DE02120300000000202051",
+      "box": {
+        "top": 2795.15,
+        "left": 429.15,
+        "width": 464.0,
+        "height": 28.0,
+        "page": 1
+      },
       "candidates": "ibans"
-    },
-    "docType": {
-      "entity": "doctype",
-      "value": "Invoice"
     }
   },
   "candidates": {
-    "paymentRecipients": [
+    "amounts": [
       {
-        "entity": "companyname",
-        "value": "Fahrrad Rückenwind",
+        "entity": "amount",
+        "value": "995.00:EUR"
+      }
+    ],
+    "ibans": [
+      {
+        "entity": "iban",
+        "value": "DE02120300000000202051",
         "box": {
-          "top": 103.69,
-          "left": 66.25,
-          "width": 107.0,
-          "height": 12.0,
+          "top": 2795.15,
+          "left": 429.15,
+          "width": 464.0,
+          "height": 28.0,
           "page": 1
         }
       },
       {
-        "entity": "companyname",
-        "value": "Fahrrad Rückenwind",
+        "entity": "iban",
+        "value": "DE02120300000000202051",
+        "box": {
+          "top": 2795.15,
+          "left": 274.2,
+          "width": 618.95,
+          "height": 470.0499999999997,
+          "page": 1
+        }
+      },
+      {
+        "entity": "iban",
+        "value": "DE02120300000000202051",
         "box": {
-          "top": 617.53,
-          "left": 66.25,
-          "width": 192.95999999999998,
-          "height": 11.040000000000077,
+          "top": 3362.55,
+          "left": 1285.55,
+          "width": 339.0,
+          "height": 25.0,
           "page": 1
         }
+      },
+      {
+        "entity": "iban",
+        "value": "DE02120300000000202051"
       }
     ],
     "bics": [
       {
         "entity": "bic",
         "value": "BYLADEM1001",
         "box": {
-          "top": 794.41,
-          "left": 282.25,
-          "width": 62.420000000000016,
-          "height": 7.920000000000073,
+          "top": 2690.5,
+          "left": 280.5,
+          "width": 350.0,
+          "height": 35.0,
           "page": 1
         }
       },
       {
         "entity": "bic",
         "value": "BYLADEM1001",
         "box": {
-          "top": 642.49,
-          "left": 66.25,
-          "width": 86.03,
-          "height": 11.039999999999964,
+          "top": 3320.55,
+          "left": 1177.55,
+          "width": 258.0,
+          "height": 25.0,
           "page": 1
         }
       }
     ],
-    "amounts": [
+    "paymentRecipients": [
       {
-        "entity": "amount",
-        "value": "995.00:EUR",
-        "box": {
-          "top": 464.89,
-          "left": 496.45,
-          "width": 29.439999999999998,
-          "height": 10.080000000000041,
-          "page": 1
-        }
+        "entity": "companyname",
+        "value": "Fahrrad Rückenwind"
       },
       {
-        "entity": "amount",
-        "value": "995.00:EUR",
+        "entity": "companyname",
+        "value": "Fahrrad Rückenwind",
         "box": {
-          "top": 464.89,
-          "left": 496.45,
-          "width": 29.439999999999998,
-          "height": 10.080000000000041,
+          "top": 446.55,
+          "left": 280.55,
+          "width": 432.99999999999994,
+          "height": 39.0,
           "page": 1
         }
-      }
-    ],
-    "ibans": [
+      },
       {
-        "entity": "iban",
-        "value": "DE02120300000000202051",
-        "box": {
-          "top": 804.49,
-          "left": 302.17,
-          "width": 88.56,
-          "height": 7.919999999999959,
-          "page": 1
-        }
+        "entity": "companyname",
+        "value": "FAHRRADÜCKENWIND GMBH"
       },
       {
-        "entity": "iban",
-        "value": "DE02120300000000202051",
+        "entity": "companyname",
+        "value": "Fahrrad Rückenwind",
         "box": {
-          "top": 666.49,
-          "left": 93.65,
-          "width": 121.82999999999998,
-          "height": 11.039999999999964,
+          "top": 2586.55,
+          "left": 281.55,
+          "width": 795.0,
+          "height": 39.0,
           "page": 1
         }
       }