Ipc 716 refactor for accessibility #831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on Android 10 IPC-756
…n ReviewView IPC-756
…iewBottomSheet IPC-756
…iewBottomSheet IPC-756
…ewFragment IPC-756
…-the-screen-while-rotation-on-Android-10 IPC 756 Keypad is not retaining on the screen while rotation on Android 10
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors keyboard handling for improved accessibility across API levels, implementing a unified approach to restore keyboard state after orientation changes and view recreation.
Key changes:
- Added keyboard state tracking and restoration for pre-API 30 devices
- Implemented focus management to maintain user context during view lifecycle events
- Created a unified keyboard display helper function
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Extensions.kt | Added showKeyboard() extension function for unified keyboard display across API levels |
| ReviewBottomSheet.kt | Implemented keyboard state persistence and focus tracking for bottom sheet dialogs |
| ReviewFragment.kt | Added keyboard restoration logic specifically for Android Q and below devices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/java/net/gini/android/internal/payment/review/reviewBottomSheet/ReviewBottomSheet.kt
Outdated
Show resolved
Hide resolved
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.