-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some beautiness #9
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Why do you remove semicolons? (It is a bad habit and discouraged all over the place as well as causes troubles with jshint, jslint and especially minification as long as you don't add extra configuration...)
-
Why don't you group ALL import statements at the top? Would make it even nicer :-)
You are fast like the meteor. With your help needs to be written a new reactive framework.
PS Now I use spaces after functions definitions. |
If you are interesting root: true
extends: default
env:
es6: true
browser: true
parserOptions:
ecmaVersion: 6
allowImportExportEverywhere: false
globals:
$: true
google: true
window: true
require: true
CSRF_TOKEN: true
rules:
indent:
- 1
- 4
quotes:
- 1
- single
linebreak-style:
- 2
- unix
semi:
- 1
- always # - never
no-undef:
- 2
space-before-function-paren:
- 2
array-bracket-spacing:
- 0
no-var:
- 0
one-var:
- 1
- never # - always
prefer-const:
- 0
comma-dangle:
- 2
- only-multiline
no-extra-parens:
- 0 |
Dear Piterden: I am very sorry, if my comment came over in a harsh way! Please forgive me!!! I apologise profoundly!!! I will check up on the semicolon issue. The source I have is somewhere at Angular, where it comes up in the discourse of minification. If I find the link again, I will post it. Thanks for your posts! I keep playing around with them and will come back! |
Added some ES6 features and formatted.