Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some beautiness #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Piterden
Copy link

Added some ES6 features and formatted.

Copy link

@rowild rowild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why do you remove semicolons? (It is a bad habit and discouraged all over the place as well as causes troubles with jshint, jslint and especially minification as long as you don't add extra configuration...)

  2. Why don't you group ALL import statements at the top? Would make it even nicer :-)

@Piterden
Copy link
Author

Piterden commented Jul 7, 2017

You are fast like the meteor. With your help needs to be written a new reactive framework.

  1. Sorry, could you give me the reference, where from did you know, about it is a bad habit to not use semicolons in the EcmaScript 6 environment.
    I'd also asked in Vue chat about it, and there I heard the opposite thing, that using of semicolons is the Mauveton.

  2. You know, you should never critic someone about his code style, but should critic him about the absence of complexity in his code. Because it's not matter really, using you single quotes, or double, but if you use double, please use double every time, at least in the limit of one application.

PS Now I use spaces after functions definitions.

@Piterden
Copy link
Author

Piterden commented Jul 7, 2017

If you are interesting

root: true
extends: default
env:
  es6: true
  browser: true
parserOptions:
  ecmaVersion: 6
  allowImportExportEverywhere: false
globals:
  $: true
  google: true
  window: true
  require: true
  CSRF_TOKEN: true
rules:
  indent:
    - 1
    - 4
  quotes:
    - 1
    - single
  linebreak-style:
    - 2
    - unix
  semi:
    - 1
    - always # - never
  no-undef:
    - 2
  space-before-function-paren:
    - 2
  array-bracket-spacing:
    - 0
  no-var:
    - 0
  one-var:
    - 1
    - never # - always
  prefer-const:
    - 0
  comma-dangle:
    - 2
    - only-multiline
  no-extra-parens:
    - 0

@rowild
Copy link

rowild commented Jul 7, 2017

Dear Piterden: I am very sorry, if my comment came over in a harsh way! Please forgive me!!! I apologise profoundly!!!

I will check up on the semicolon issue. The source I have is somewhere at Angular, where it comes up in the discourse of minification. If I find the link again, I will post it.
However, it is very likely that there are changes in ES6, which I missed... so please ignore my statement!

Thanks for your posts! I keep playing around with them and will come back!

@Piterden
Copy link
Author

Piterden commented Jul 7, 2017

Thank you!
Peace!
no_wp
))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants