Add canonical package location to SwiftPMCacheKey to differentiate the same target when its package is changed from remote one to local one (or vice-versa) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et when its package is changed from remote one to local one (or vice-versa)
freddi-kit
approved these changes
Dec 12, 2024
|
This might be insufficient so converting to draft for now. |
…differentiate remote and local packages
ikesyo
changed the title
|
I fixed the implementation using CanonicalPackageLocation instead of PackageIdentity and added the test case. |
giginet
reviewed
Dec 13, 2024
| @@ -96,6 +96,7 @@ extension PinsStore.PinState: @retroactive Hashable { | |||
| } | |||
|
|
|||
| public struct SwiftPMCacheKey: CacheKey { | |||
| public var canonicalPackageLocation: String | |||
There was a problem hiding this comment.
I'm worried about the remote URL being embedded. If it's used in a mirrored repository, all caches will be expired. I think it's better to be it Optional and it should have only for local packages.
There was a problem hiding this comment.
Thanks for the suggestion, I addressed this in 0f6e237.
ikesyo
force-pushed
the
add-packageidentity-to-swiftpmcachekey
branch
from
103d4c6 to
507be71
Compare
For remote packages, dependency mirroring will be a problem, so avoiding.
ikesyo
force-pushed
the
add-packageidentity-to-swiftpmcachekey
branch
from
507be71 to
0f6e237
Compare
giginet
approved these changes
Dec 13, 2024
freddi-kit
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no package information in SwiftPMCacheKey.
ref: https://github.com/swiftlang/swift-package-manager/blob/bc689418acad746af6f2e24e6bef640e411d9bd7/Sources/PackageModel/PackageIdentity.swift#L16-L19