Fix build errors in Xcode16-RC #141
Merged
+2
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
reviewed
Sep 12, 2024
Comment on lines
-13
to
-25
| extension BuildConfiguration: @retroactive ExpressibleByArgument { | ||
| public init?(argument: String) { | ||
| switch argument.lowercased() { | ||
| case "debug": | ||
| self = .debug | ||
| case "release": | ||
| self = .release | ||
| default: | ||
| return nil | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This extension was also required for Swift 5 & 6.
Please move L34 to the outside of the preprocessor block.
There was a problem hiding this comment.
The BuildConfiguration extension is already outside the preprocessor block.
If my perception is wrong, I would like to know!
giginet
approved these changes
Sep 12, 2024
Comment on lines
-13
to
-25
| extension BuildConfiguration: @retroactive ExpressibleByArgument { | ||
| public init?(argument: String) { | ||
| switch argument.lowercased() { | ||
| case "debug": | ||
| self = .debug | ||
| case "release": | ||
| self = .release | ||
| default: | ||
| return nil | ||
| } | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed an error that occurs when building with Xcode 16 Release Candidate.
This change is also included in #140, but I wanted to use it immediately, so I created a small separate PR.
Changes
@retroactivedeclarations