Link all dependencies of targets #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
force-pushed
the
link-dependencies-of-targets
branch
from
cd41259 to
947a7cd
Compare
freddi-kit
approved these changes
May 29, 2024
giuk-jung
approved these changes
May 29, 2024
Merged
giginet
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link all dependencies to the target automatically. This setting is required when the dependencies are built as dynamic frameworks.
In the original PIFBuilder of SwiftPM, PackageProducts have link frameworks to their dependencies. However, Scipio ignores this and use library target to make framework instead.
So we need to add dependencies to the framework link phase of the library targets.