Merge pull request #107 from giginet/infoplist-version

Add CFBundleVersion and CFBundleShortVersionString to Info.plist
giginet · Oct 10, 2023 · f429f97 · f429f97
2 parents 1d89d20 + 42dfdbb
commit f429f97
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/Sources/ScipioKit/Producer/PIF/PIFGenerator.swift b/Sources/ScipioKit/Producer/PIF/PIFGenerator.swift
@@ -210,7 +210,11 @@ private struct PIFLibraryTargetModifier {
         settings[.SKIP_INSTALL] = "NO"
         settings[.INSTALL_PATH] = "/usr/local/lib"
         settings[.ONLY_ACTIVE_ARCH] = "NO"
+
         settings[.GENERATE_INFOPLIST_FILE] = "YES"
+        // These values are required to ship built frameworks to AppStore as embedded frameworks
+        settings[.MARKETING_VERSION] = "1.0"
+        settings[.CURRENT_PROJECT_VERSION] = "1"
 
         // Set framework type
         switch buildOptions.frameworkType {

diff --git a/Tests/ScipioKitTests/RunnerTests.swift b/Tests/ScipioKitTests/RunnerTests.swift
@@ -15,11 +15,25 @@ private let clangPackagePath = fixturePath.appendingPathComponent("ClangPackage"
 private let clangPackageWithCustomModuleMapPath = fixturePath.appendingPathComponent("ClangPackageWithCustomModuleMap")
 private let clangPackageWithUmbrellaDirectoryPath = fixturePath.appendingPathComponent("ClangPackageWithUmbrellaDirectory")
 
+private struct InfoPlist: Decodable {
+    var bundleVersion: String
+    var bundleShortVersionString: String
+    var bundleExecutable: String
+
+    enum CodingKeys: String, CodingKey {
+        case bundleVersion = "CFBundleVersion"
+        case bundleShortVersionString = "CFBundleShortVersionString"
+        case bundleExecutable = "CFBundleExecutable"
+    }
+}
+
 final class RunnerTests: XCTestCase {
     private let fileManager: FileManager = .default
     lazy var tempDir = fileManager.temporaryDirectory
     lazy var frameworkOutputDir = tempDir.appendingPathComponent("XCFrameworks")
 
+    private let plistDecoder: PropertyListDecoder = .init()
+
     override class func setUp() {
         LoggingSystem.bootstrap { _ in SwiftLogNoOpLogHandler() }
 
@@ -75,6 +89,17 @@ final class RunnerTests: XCTestCase {
                 "Binary should be a dynamic library"
             )
 
+            let infoPlistPath = deviceFramework.appendingPathComponent("Info.plist")
+            let infoPlistData = try XCTUnwrap(
+                fileManager.contents(atPath: infoPlistPath.path),
+                "Info.plist should be exist"
+            )
+
+            let infoPlist = try plistDecoder.decode(InfoPlist.self, from: infoPlistData)
+            XCTAssertEqual(infoPlist.bundleExecutable, library)
+            XCTAssertEqual(infoPlist.bundleVersion, "1")
+            XCTAssertEqual(infoPlist.bundleShortVersionString, "1.0")
+
             XCTAssertFalse(fileManager.fileExists(atPath: simulatorFramework.path),
                            "Should not create Simulator framework")
         }