Fixing indirections#296
Open
vidsinghal wants to merge 2321 commits into
Open
Conversation
update stack resolver to a version compatible with our version of safe
- Added wrappingMul helper function using Word32 arithmetic for safe overflow handling in AOS and SOA DBQuery programs - Updated mixSeed to use Word32 wrapping arithmetic to prevent overflow - Reduced depth multipliers from 220→20 (factor of 11) and 170→15 (factor of ~11) to reduce intermediate value magnitude - Applied wrappingMul to critical multiplications: lRows*rRows and childRows*sel - Imported Data.Word and Data.Int for Word32/Int32 conversions These changes ensure that the benchmark programs using buildQuery and sumRows no longer overflow when dealing with large intermediate values, particularly at higher depth parameters. Co-Authored-By: Claude <noreply@anthropic.com>
vidsinghal
force-pushed
the
fixing_indirections
branch
from
February 22, 2026 01:08
61c2280 to
7db0052
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing in-directions (copy of ADTs) for SoA