uploaded movie review microservice benchmark

[PL-666]

No description provided.

[vidsinghal]

Can you rename it from examples/movie to something more meaningful like example/movie-micro-service etc. ?

[PL-666]

ok

…

On Tue, Sep 26, 2023 at 12:13 PM Vidhush Singhal ***@***.***> wrote: Can you rename if from examples/movie to something more meaningful like example/movie-micro-service etc. ? — Reply to this email directly, view it on GitHub <#226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANAV6OKGV3GGQAP63ZOORP3X4L5MNANCNFSM6AAAAAA5H6JKLQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[PL-666]

Can you rename it from examples/movie to something more meaningful like example/movie-micro-service etc. ?

So I need to open another pull request then?

[vidsinghal]

Can you rename it from examples/movie to something more meaningful like example/movie-micro-service etc. ?

So I need to open another pull request then?

No. modify it locally and then use -f to force push it to origin . It will automatically update the PR here.

[vidsinghal]

Your movie test failed: https://github.com/iu-parfunc/gibbon/actions/runs/6315149798/job/17147823949#step:14:101

[PL-666]

Yeah, I forgot to update the dir in test-gibbon-examples accordingly after changing the name of the directory. It should be fixed now.

[vidsinghal]

Yeah, I forgot to update the dir in test-gibbon-examples accordingly after changing the name of the directory. It should be fixed now.

What is this? https://github.com/iu-parfunc/gibbon/actions/runs/6317817919/job/17158707670?pr=226#step:14:101
Run the tests locally to make sure they are passing, then proceed to make a PR.
Use ./run_all_tests.sh in the main directory

[PL-666]

Ok, this is because I name the file as movies.hs instead of Movies.hs. Therefore the module could not be found. Now I changed the name of the file, I think the module could be found.

[PL-666]

Yeah, I forgot to update the dir in test-gibbon-examples accordingly after changing the name of the directory. It should be fixed now.

What is this? https://github.com/iu-parfunc/gibbon/actions/runs/6317817919/job/17158707670?pr=226#step:14:101 Run the tests locally to make sure they are passing, then proceed to make a PR. Use ./run_all_tests.sh in the main directory

Ok, I will make sure ./run_all_tests.sh succeed first. Somehow when I changed the name of the file, the change does not occur when I commit it.

[ulysses4ever]

@PL-666 any interetest in nailing this one?

[PL-666]

@PL-666 any interetest in nailing this one?

There was still some bug that I could not figure out the fix. Let me try to fix it over the weekend. Sorry about that.

[ulysses4ever]

@PL-666 no problem at all! If you have trouble with it, we can also meet and look into it together (virtually or at Purdue).

[PL-666]

@PL-666 no problem at all! If you have trouble with it, we can also meet and look into it together (virtually or at Purdue).

@ulysses4ever So there is a segmentation fault that occurs when I increase the size of testcases beyond 100, previously I could increase it to something like 100,000 with out causing any problem. But due to a past update, the segmentation fault occurred and I have no idea how to fix it.

[ulysses4ever]

@PL-666 thanks for the update! Could you post the directions for how to reproduce the segafult here?

[PL-666]

@ulysses4ever Basically compiling and running testInsertMovie.hs would cause the segfault. If I change line 14 from mvt = iterate (testInsert 1000 Root) to mvt = iterate (testInsert 100 Root) then the segfault does not happen.

[ulysses4ever]

Thanks! I’ll try to look into it early next week.