Skip to content

Commit

Permalink
Replace kubeval with kubeconform
Browse files Browse the repository at this point in the history
The kubeval tool does not seem to be maintained anymore.
  • Loading branch information
uvegla committed Jun 20, 2022
1 parent 8139c20 commit 6499cef
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/diff-preview.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
env:
dyff_ver: 1.5.4
kubeval_ver: 0.16.1
kubeconform_ver: 0.4.13
steps:
- run: sudo apt-get install -y yamllint
- name: install dyff
Expand All @@ -24,12 +24,12 @@ jobs:
- run: which dyff
- uses: giantswarm/install-binary-action@v1
with:
binary: kubeval
download_url: "https://github.com/instrumenta/kubeval/releases/download/v${version}/kubeval-linux-amd64.tar.gz"
smoke_test: "${binary} --version"
binary: kubeconform
download_url: "https://github.com/yannh/kubeconform/releases/download/v${version}/kubeconform-linux-amd64.tar.gz"
smoke_test: "${binary} -v"
tarball_binary_path: "${binary}"
version: ${{ env.kubeval_ver }}
- run: which kubeval
version: ${{ env.kubeconform_ver }}
- run: which kubeconform
- run: ls -la /opt/hostedtoolcache
- uses: actions/checkout@v3
- name: template all for the new branch
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ jobs:
needs: pre-commit
runs-on: ubuntu-latest
env:
kubeval_ver: 0.16.1
kubeconform_ver: 0.4.13
steps:
- run: sudo apt-get install -y yamllint
- uses: giantswarm/install-binary-action@v1
with:
binary: kubeval
download_url: "https://github.com/instrumenta/kubeval/releases/download/v${version}/kubeval-linux-amd64.tar.gz"
smoke_test: "${binary} --version"
binary: kubeconform
download_url: "https://github.com/yannh/kubeconform/releases/download/v${version}/kubeconform-linux-amd64.tar.gz"
smoke_test: "${binary} -v"
tarball_binary_path: "${binary}"
version: ${{ env.kubeval_ver }}
version: ${{ env.kubeconform_ver }}
- name: cache validation tools
uses: actions/cache@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion docs/appendices.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ For `yq` the [github.com/mikefarah/yq](https://github.com/mikefarah/yq/) version
You need the following tools installed to use [test-all-ffb](/tools/test-all-ffb) script.

- `yamllint` of [github.com/adrienverge/yamllint](https://github.com/adrienverge/yamllint)
- `kubeval` of [github.com/instrumenta/kubeval](https://github.com/instrumenta/kubeval)
- `kubeconform` of [github.com/yannh/kubeconform](https://github.com/yannh/kubeconform)
4 changes: 2 additions & 2 deletions tools/test-all-ffb
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ test() {
echo "Testing: $mc_name $org_name $wc_name $dir_name"
echo -n "yamllint: "
./tools/fake-flux-build build "$mc_name" "$org_name" "$wc_name" "$dir_name" | yamllint - && echo "OK"
echo "kubeval: "
./tools/fake-flux-build build "$mc_name" "$org_name" "$wc_name" "$dir_name" | kubeval --ignore-missing-schemas
echo "kubeconform: "
./tools/fake-flux-build build "$mc_name" "$org_name" "$wc_name" "$dir_name" | kubeconform -ignore-missing-schemas -output text | sed s/stdin\ -\ //g
echo ""
else
echo "---"
Expand Down

0 comments on commit 6499cef

Please sign in to comment.