Skip to content

feat: add optional displayName to kagent ModelConfig entries#200

Merged
marians merged 1 commit into
mainfrom
feat/modelconfig-display-name
Jul 8, 2026
Merged

feat: add optional displayName to kagent ModelConfig entries#200
marians merged 1 commit into
mainfrom
feat/modelconfig-display-name

Conversation

@marians

@marians marians commented Jul 8, 2026

Copy link
Copy Markdown
Member

What

Adds an optional displayName to each agents.models[] entry. When set, it is rendered as the ui.giantswarm.io/display-name annotation on the generated kagent ModelConfig CR so the UI can show a friendly label. When omitted, no annotations: block is emitted.

This also adds the previously-missing agents.models schema to both values.schema.json files, so model entries are now validated.

Changes

  • Template (agentic-platform-connectivity/templates/kagent/agents/modelconfigs.yaml): render the annotation only when displayName is present, via a {{- with .displayName }} guard.
  • Schema (both values.schema.json, kept in sync): new agents.models array schema — required name/provider/model/apiKeySecret, optional displayName/apiKeySecretKey, additionalProperties: false.
  • Values examples (both values.yaml): added the commented displayName example line.
  • CHANGELOG: entry under ### Added.

Verification

helm template on the connectivity chart:

  • with displayNameui.giantswarm.io/display-name: "…" rendered under metadata.annotations.
  • without displayName → no annotations: block, no error.
  • unknown field → rejected by schema (additional properties '…' not allowed), confirming validation is enforced.

helm lint passes on both charts.

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

Each agents.models[] entry may now carry an optional displayName, rendered
as the ui.giantswarm.io/display-name annotation on the generated kagent
ModelConfig CR. When omitted, no annotations block is emitted.

Also adds the previously-missing agents.models schema to both values.schema.json
files (required name/provider/model/apiKeySecret, optional displayName/
apiKeySecretKey, additionalProperties: false), so model entries are validated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@marians marians requested a review from a team as a code owner July 8, 2026 12:12
@marians marians merged commit 1ae025f into main Jul 8, 2026
8 checks passed
@marians marians deleted the feat/modelconfig-display-name branch July 8, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants