feat: add optional displayName to kagent ModelConfig entries#200
Merged
Conversation
Each agents.models[] entry may now carry an optional displayName, rendered as the ui.giantswarm.io/display-name annotation on the generated kagent ModelConfig CR. When omitted, no annotations block is emitted. Also adds the previously-missing agents.models schema to both values.schema.json files (required name/provider/model/apiKeySecret, optional displayName/ apiKeySecretKey, additionalProperties: false), so model entries are validated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
paurosello
approved these changes
Jul 8, 2026
fiunchinho
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
displayNameto eachagents.models[]entry. When set, it is rendered as theui.giantswarm.io/display-nameannotation on the generated kagentModelConfigCR so the UI can show a friendly label. When omitted, noannotations:block is emitted.This also adds the previously-missing
agents.modelsschema to bothvalues.schema.jsonfiles, so model entries are now validated.Changes
agentic-platform-connectivity/templates/kagent/agents/modelconfigs.yaml): render the annotation only whendisplayNameis present, via a{{- with .displayName }}guard.values.schema.json, kept in sync): newagents.modelsarray schema — requiredname/provider/model/apiKeySecret, optionaldisplayName/apiKeySecretKey,additionalProperties: false.values.yaml): added the commenteddisplayNameexample line.### Added.Verification
helm templateon the connectivity chart:displayName→ui.giantswarm.io/display-name: "…"rendered undermetadata.annotations.displayName→ noannotations:block, no error.additional properties '…' not allowed), confirming validation is enforced.helm lintpasses on both charts.Checklist
values.yamlandvalues.schema.jsonare valid.