fix(connectivity): allow forwarded klausGateway.slack.* props in schema#192
Merged
Conversation
The umbrella forwards its whole klausGateway block to the connectivity HelmRelease, but the connectivity slack schema had additionalProperties:false and only declared enabled/mode/secretName, so a real install (gazelle) failed the upgrade with "Additional property dmOnly/botToken/signingSecret/appToken is not allowed". Declare them (forwarded-only; consumed by the klaus-gateway subchart) so validation passes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentic-platform-connectivityHelmRelease upgrade to 1.18.0 failed schema validation:Additional property dmOnly/botToken/signingSecret/appToken is not allowedunderklausGateway.slack.klausGatewayblock to the connectivity HelmRelease viaforwardAllValues, but the connectivityslackschema hadadditionalProperties: falseand only declaredenabled/mode/secretName.Test plan
Made with Cursor