fix(kagent): gate agent agentgateway routes on agentgateway ingress mode#181
Merged
Conversation
The template was gated only on kagent.enabled, so AgentgatewayBackend and HTTPRoute resources were rendered on clusters running muster-direct mode (no agentgateway data plane). Gate on the existing ingress.agentgateway helper, which returns true only for agentgateway-muster and agentgateway-direct modes.
Agent A2A endpoints are consumed in-cluster (by other agents and the kagent controller) — not by external clients. The public route added unnecessary attack surface; the inner agentgateway route is sufficient. External A2A access can be added via extraObjects when explicitly needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes for
agentgateway-backends.yamlintroduced in #177.Gate on ingress mode: resources were rendered whenever
kagent.enabledand the agent'senabledwere true, regardless of ingress mode. On clusters runningmuster-direct(e.g. glean) there is no agentgateway data plane — theAgentgatewayBackendandHTTPRoutewould be orphaned. Now gated on the existingagentic-platform.ingress.agentgatewayhelper (agentgateway-musteroragentgateway-directonly).Drop public HTTPRoute: agent A2A endpoints are consumed in-cluster by other agents and the kagent controller. A public outer route adds attack surface with no current use case. External A2A access can be added via
extraObjectswhen explicitly needed.