add some count API #5
Conversation
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: no user matched threshold 10 See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -66,6 +66,20 @@ public PostResponse getAllPosts( | |||
| return postService.getAllPosts(pageNo, pageSize, sortBy, sortDir); | |||
| } | |||
|
|
|||
| @Operation( | |||
There was a problem hiding this comment.
The summary and description in the @Operation annotation are incorrect. They should describe the actual functionality of the method, which is to count all posts.
| ) | ||
| // get post by id | ||
| @GetMapping("/count") | ||
| public int countAllPost() { |
There was a problem hiding this comment.
Consider returning a ResponseEntity instead of a raw integer. This would allow you to include HTTP status codes and potentially other information in the response.
| @@ -129,4 +143,9 @@ | |||
| List<PostDto> postDtos = postService.getPostsByCategory(categoryId); | |||
| return ResponseEntity.ok(postDtos); | |||
| } | |||
|
|
|||
| @GetMapping("/category/{id}/count") | |||
There was a problem hiding this comment.
Consider wrapping the returned integer in a ResponseEntity for consistency with the other endpoints in your controller.
| @@ -129,4 +143,9 @@ | |||
| List<PostDto> postDtos = postService.getPostsByCategory(categoryId); | |||
| return ResponseEntity.ok(postDtos); | |||
| } | |||
|
|
|||
| @GetMapping("/category/{id}/count") | |||
| public int countPostsByCategory(@PathVariable("id") Long categoryId){ | |||
There was a problem hiding this comment.
Add @Valid annotation to validate the categoryId path variable.
| @@ -118,6 +118,16 @@ public List<PostDto> getPostsByCategory(Long categoryId) { | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| @Override | |||
| public int countAllPost() { | |||
| return 0; | |||
There was a problem hiding this comment.
The countAllPost() method currently returns 0. Please implement the logic to return the actual count of all posts.
|
|
||
| @Override | ||
| public int countPostByCategory(Long categoryId) { | ||
| return 0; |
There was a problem hiding this comment.
The countPostByCategory(Long categoryId) method currently returns 0. Please implement the logic to return the actual count of posts in the specified category.
Why this PR is needed
This PR is needed to add new functionality to the blog application. It introduces two new endpoints to the
PostControllerthat allow users to count the total number of posts and the number of posts in a specific category. This is part of the task: https://moneyforwardvietnam.atlassian.net/browse/SCI-What I did in this PR
PostServiceinterface:countAllPost()andcountPostByCategory(Long categoryId).PostServiceImplclass.PostController:GET /countandGET /category/{id}/count. These endpoints call the new methods in thePostService.How to check
/countto get the total number of posts./category/{id}/countto get the number of posts in a specific category.Checklist
unit-testself-reviewandtestof my codeperf issuenew properties? If then you need to create properties on:task_definition_app.json,task_definition_app_beta.jsonandAWS paramStoreSTG/PRODplz prepareliquibase script