-
-
Notifications
You must be signed in to change notification settings - Fork 39
Appel420 patch 7 #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appel420 patch 7 #975
Conversation
This workflow triggers APIsec scans on push and pull request events for the main branch, and allows manual execution. It includes steps for running the scan and uploading results in SARIF format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increments the package version from 1.0.667 to 1.0.668 and adds two new GitHub Actions workflow files for manual workflow triggering and API security scanning.
- Version bump from 1.0.667 to 1.0.668 in package files
- Addition of a manual workflow for greeting functionality
- Addition of an APIsec security scanning workflow
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Version incremented to 1.0.668 |
| package-lock.json | Lockfile version updated to match package.json |
| .github/workflows/manual.yml | New manual workflow that accepts a name input and outputs a greeting |
| .github/workflows/apisec-scan.yml | New workflow for automated API security scanning using APIsec |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # The Password of the APIsec user with which the scans will be executed | ||
| apisec-password: ${{ secrets.apisec_password}} | ||
| # The name of the project for security scan | ||
| apisec-project: "VAmPI" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded project name 'VAmPI' appears to be a placeholder or example value. This should be updated to reflect the actual project name '@ghostery/trackerdb' or made configurable via secrets/variables.
| apisec-project: "VAmPI" | |
| apisec-project: "@ghostery/trackerdb" |
| # This is a basic workflow that is manually triggered | ||
|
|
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow appears to be a test/example workflow with no clear purpose for the trackerdb project. Consider adding documentation explaining why this greeting workflow is needed, or remove it if it was added unintentionally.
| # This is a basic workflow that is manually triggered | |
| # This workflow is intentionally included in the trackerdb project as a simple example of a manually-triggered GitHub Actions workflow. | |
| # It can be used by contributors to test that GitHub Actions are functioning correctly in this repository, and as a template for adding future manual jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
|
Closing, since it is unclear what problem this is intending to solve. Thus, I have to consider it spam. |
No description provided.