Skip to content

Conversation

@Appel420
Copy link

No description provided.

Appel420 and others added 3 commits October 28, 2025 21:44
This workflow triggers APIsec scans on push and pull request events for the main branch, and allows manual execution. It includes steps for running the scan and uploading results in SARIF format.
Copilot AI review requested due to automatic review settings October 29, 2025 02:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increments the package version from 1.0.667 to 1.0.668 and adds two new GitHub Actions workflow files for manual workflow triggering and API security scanning.

  • Version bump from 1.0.667 to 1.0.668 in package files
  • Addition of a manual workflow for greeting functionality
  • Addition of an APIsec security scanning workflow

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Version incremented to 1.0.668
package-lock.json Lockfile version updated to match package.json
.github/workflows/manual.yml New manual workflow that accepts a name input and outputs a greeting
.github/workflows/apisec-scan.yml New workflow for automated API security scanning using APIsec

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# The Password of the APIsec user with which the scans will be executed
apisec-password: ${{ secrets.apisec_password}}
# The name of the project for security scan
apisec-project: "VAmPI"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded project name 'VAmPI' appears to be a placeholder or example value. This should be updated to reflect the actual project name '@ghostery/trackerdb' or made configurable via secrets/variables.

Suggested change
apisec-project: "VAmPI"
apisec-project: "@ghostery/trackerdb"

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +2
# This is a basic workflow that is manually triggered

Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow appears to be a test/example workflow with no clear purpose for the trackerdb project. Consider adding documentation explaining why this greeting workflow is needed, or remove it if it was added unintentionally.

Suggested change
# This is a basic workflow that is manually triggered
# This workflow is intentionally included in the trackerdb project as a simple example of a manually-triggered GitHub Actions workflow.
# It can be used by contributors to test that GitHub Actions are functioning correctly in this repository, and as a template for adding future manual jobs.

Copilot uses AI. Check for mistakes.
Copy link
Author

@Appel420 Appel420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

@philipp-classen
Copy link
Member

Closing, since it is unclear what problem this is intending to solve. Thus, I have to consider it spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants