Add iOS support via Appium WebDriverAgent#8
Draft
blah-mad wants to merge 208 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR turns Ghost in the Droid from an Android-only automation harness into a cross-platform mobile agent with first-class iOS support. Android keeps the existing ADB/Portal path; iOS devices use Appium XCUITest and WebDriverAgent, with real iPhone support as the product target and simulator support for development/CI.
Addresses #7.
What Changed
IOSDevicebackend ingitd/bots/common/ios.pywith Appium/WDA session management, screenshots, UI tree dump/normalization, taps, swipes, typing, app launch, clipboard, notifications, browser navigation, and recovery-oriented health checks.simctl, and per-device iOS config via env/JSON/file.https://text.npr.org/, extract visible headlines/articles through web context/native/OCR fallback, open articles, and return structured snippets plus screenshots/log evidence.elements_ios.yaml, platform compatibility fields, the iOS browser/news demo skill, and smoke-level TikTok iOS workflows.Issue #7 Coverage
The RFC asked for:
gitd/bots/common/ios.py, with shared routing ingitd/bots/common/device.pyand platform-aware services/routers.IOSDevicePOC: Implemented well beyond screenshot/tap/dump UI, including launch, text entry, browser controls, app state, clipboard, notifications, and session recovery.docs/SETUP_IOS.md, README updates, API/MCP references, and dashboard recovery copy.Validation
Automated checks run on this branch:
Other validation performed while building the branch:
uv run pytest # 377 passed, 4 skippedLive validation performed locally:
ios:00008110-0016443101D0401E) through Appium/WDA.1170x2532.https://text.npr.org/: extracted 5 headlines and 3 article bodies.ios:32918B6B-71E5-4A14-94C6-97F0B8B2DC44) through Appium/WDA.1178x2556.Known Limits / Follow-Ups
Maintainer Trial Guide
Use this section as a quick handoff guide for reviewing the iOS path.
For a real iPhone:
For a simulator:
For multiple iOS devices/simulators, prefer
IOS_DEVICES_JSONso each target can have its own bundle ID and MJPEG port.python3 run.py cd frontend npm install npx vite --host 0.0.0.0 --port 6175Open
http://127.0.0.1:6175, choose theios:<udid>device, and start the stream. iOS should showWDA MJPEG; Android should keep its existing WebRTC/MJPEG behavior.Expected result:
result.jsonhasok: true, at least 5 headlines, and article snippets for the requested articles. If setup fails, inspecthealth.json; it should include actionableconnection.status,recommended_fix, and recovery steps.ios:<udid>refs should route to WDA-backed implementations where available.