Fix schemathesis-compatability for list-dict-fields#120
Open
henrikhorluck wants to merge 6 commits into
Open
Conversation
…include examples that fail the schema validation done by schemathesis
…t fields. For example, the regex `\d+\.field1` is used in the API schema to indicate that the API will return attribute values like `0.field1`, `1.field1`. Previously, attr was incorrectly specified as an enum with the value `INDEX.field1` that represents the actual API output. fix ghazi-git#76
DICT_KEY_IN_API_SCHEMA settings
…rializers and list/dict fields
…/dict fields in the generated API schema
1. Ensure the patterns are anchored, which fixes the oneOf-error from the schema validation. 2. Uses `[\s\S]` such that newlines are included in the pattern, which was caught by schemathesis. 3. Add parent-fields to expected fields, as caught by schemathesis, as e.g. a null-value can render as an error in the index itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated rebase of #79, with the additional fix that the patterns are anchored, which fixes the issue noted in #76 (comment) wrt. it being valid under either of an oneOf, the schemathesis-tests now pass, and there are additional fixes surfaced by schemathesis wrt. direct index/fields (e.g.:
data=[None]givesattr: "0") and newlines in dict keys (so[\s\S]instead of.).Also updated to schemathesis 4.
This was assisted by Opus 4.8 and GPT 5.5, I did not find any LLM-policy.