Fixed VAD to work when using whisper_full_with_state #3423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
whisper_full_with_state
doesn't work with VAD.The main inference method is
whisper_full_with_state
. This method takes awhisper_context
and awhisper_state
. On top of this method are built 2 convenience methods,whisper_full
andwhisper_full_parallel
.The VAD logic is currently only implemented in those convenience methods, but not in
whisper_full_with_state
itself. This is an issue whenever we need to deal with more than one state (when processing multiple real time streams for example).This pull request moves the logic into
whisper_full_with_state
and fix a few incorrect calls toctx->state
instead ofstate
directly.