Skip to content

vulkan: throw system error instead of SIGABRT during init on older devices #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

vulkan: throw system error instead of SIGABRT during init on older devices #16156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df7593
Throw system error on old Vulkan driver rather than SIGABRT
DmyMi Sep 21, 2025
ad2a784
Optionally handle any potential error in vulkan init
DmyMi Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ggml/src/ggml-vulkan/ggml-vulkan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4450,7 +4450,7 @@ static void ggml_vk_instance_init() {

if (api_version < VK_API_VERSION_1_2) {
std::cerr << "ggml_vulkan: Error: Vulkan 1.2 required." << std::endl;
GGML_ABORT("fatal error");
throw vk::SystemError(vk::Result::eErrorFeatureNotPresent, "Vulkan 1.2 required");
}

vk::ApplicationInfo app_info{ "ggml-vulkan", 1, nullptr, 0, api_version };
Expand Down Expand Up @@ -12726,6 +12726,12 @@ ggml_backend_reg_t ggml_backend_vk_reg() {
} catch (const vk::SystemError& e) {
VK_LOG_DEBUG("ggml_backend_vk_reg() -> Error: System error: " << e.what());
return nullptr;
} catch (const std::exception &e) {
VK_LOG_DEBUG("ggml_backend_vk_reg() -> Error: " << e.what());
return nullptr;
} catch (...) {
VK_LOG_DEBUG("ggml_backend_vk_reg() -> Error: unknown exception during Vulkan init");
return nullptr;
}
}

Expand Down