Fix hlsl storage format generation #6993
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Previously we generated a
vec2
for rg8unorm on hlsl as the storage type; however, this is for the output variable, not the stored type. This PR makes this always a vec4 unless it's a one length type because: 1. They seem to be auto convertible to a vec4 2. it breaks image atomics. I would prefer these to be vec4s too but I can't find a way to not break image atomics.Testing
Adds a new naga snapshot which loads and stores to storage textures which are r8unorm, rg8unorm and rgba8unorm.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.