[naga] add back PartialEq derives for some types
#6045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
added
the
PR: needs back-porting
This was referenced Jul 25, 2024
teoxoy
removed
the
PR: needs back-porting
jimblandy
approved these changes
Jul 26, 2024
teoxoy
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 1f4f675)
Wumpf
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5818 since
naga_oilneeds these.Ideally these types shouldn't need
PartialEqbut the current implementation ofnaga_oilrequires them.Once we get to #5713 we can revert this PR.
cc @robtfm @stefnotch