Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Check cargo doc in CI #245

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Check cargo doc in CI #245

merged 2 commits into from
Apr 9, 2020

Conversation

hecrj
Copy link
Contributor

@hecrj hecrj commented Apr 7, 2020

This PR makes CI run cargo doc using the latest nightly.

It is currently panicking here:

https://github.com/rust-lang/rust/blob/6dee5f1126dfd5c9314ee5ae9d9eb010e35ef257/src/librustdoc/passes/mod.rs#L411

I thought it was an incorrect link causing it, but the issue seems to persist even after fixing the link.

Update: Issue opened upstream by @grovesNL (rust-lang/rust#70874).

@kvark
Copy link
Member

kvark commented Apr 8, 2020

Thank you!
if this fails for now, we should have allow-fail on it
bors r+

bors bot added a commit that referenced this pull request Apr 8, 2020
245: Check `cargo doc` in CI r=kvark a=hecrj

This PR makes CI run `cargo doc` using the latest nightly.

It is currently panicking here:

https://github.com/rust-lang/rust/blob/6dee5f1126dfd5c9314ee5ae9d9eb010e35ef257/src/librustdoc/passes/mod.rs#L411

I thought it was an incorrect link causing it, but the issue seems to persist even after fixing the link.

__Update__: Issue opened upstream by @grovesNL (rust-lang/rust#70874).

Co-authored-by: Héctor Ramón Jiménez <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 8, 2020

Build failed

@hecrj
Copy link
Contributor Author

hecrj commented Apr 9, 2020

I have added the new job to the allow_failures section and rebased.

@kvark
Copy link
Member

kvark commented Apr 9, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 9, 2020

Build succeeded

@bors bors bot merged commit 0c4298b into gfx-rs:master Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants