docs: add Mantine 9.3 window menu demos - #31
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR adds two new documentation demos showcasing Mantine 9.3's context menu and option menu capabilities within the mantine-window component. Context Menu demo demonstrates right-click menus using Menu.ContextMenu, while Menu Bar demo shows searchable menus with toggleable and radio-select options. Both are registered in the demo system and documented in docs.mdx. ChangesMenu Feature Demos and Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @ded-furby, thank you for picking this up so quickly — the implementation was clean and followed the issue spec correctly, which is genuinely appreciated. That said, I've decided to go with an alternative take in #32 where every menu entry drives real window/workspace state (duplicating/closing actual windows, creating/removing canvas layers), which fits the desktop metaphor this component is built around. A couple of details from your version also needed adjustments (the hardcoded Closing this in favor of #32, but thanks again for contributing — PRs are always welcome. |
Summary
Menu.ContextMenudemo that shows desktop-style right-click actions inside aWindowMenu.Search,Menu.CheckboxItem, andMenu.RadioGroupdocs/docs.mdxand export them from the demo indexCloses #30.
Validation
yarn buildyarn docs:buildyarn format:testyarn lintSummary by CodeRabbit
Documentation